Date: 14 Jan 2002 09:41:26 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Anders Andersson <anders@hack.org> Cc: gnome@FreeBSD.org Subject: Re: x11/gnomeapplets Message-ID: <1010994025.64927.16.camel@notebook> In-Reply-To: <20020106195552.GD32992@sushi.sanyusan.se> References: <20020103211310.GA320@sushi.sanyusan.se> <20020106195552.GD32992@sushi.sanyusan.se>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sun, 2002-01-06 at 21:55, Anders Andersson wrote:
> On Thu, Jan 03, 2002 at 10:13:10PM +0100, Anders Andersson wrote:
> > I got inspired bye Alfreds patch to sysutils/xbattbar which changed
> > xbattbar to use a readonly /dev/apm.
> >
> > So I patched gnomeapplets battery_applet to do this at it seems to work
> > fine on -CURRENT at least.
> >
> > [root@sushi gnome-applets-1.4.0.4]# diff -u battery/read-battery.c.orig
> > battery/read-battery.c
> > --- battery/read-battery.c.orig Thu Jan 3 22:05:06 2002
> > +++ battery/read-battery.c Thu Jan 3 21:42:30 2002
> > @@ -170,7 +170,7 @@
> > *hours_remaining = -1;
> > *minutes_remaining = 1;
> >
> > - fd = open(APMDEV, O_RDWR);
> > + fd = open(APMDEV, O_RDONLY);
> > if (fd == -1)
> > {
> > g_error (_("Cannot open /dev/apm; can't get data."));
> >
> >
> > Do any of you know why it was O_RDWR in the first place? I didnt find
> > any explanation on the gnome cvs commit logs.
>
> Well, replying myself...
>
> >From what I can understand we want this in 4.5-RELEASE since it allows
> user to use battery_applet without chmodding /dev/apm.
>
> Or am I out in the blue here?
Sorry for the delay - I was a little busy lately. I'll test and if it's
OK then commit your patch today.
Thanks!
-Maxim
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD8DBQA8QotooNu5t4iCBa8RAoShAJ4xLhR/fyzdllxxS7NjX4scn6LtZwCdGwLQ
e5dfw1zCNxLxgwBpSC1HAaA=
=U5p4
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1010994025.64927.16.camel>