From owner-freebsd-current@FreeBSD.ORG Mon Dec 17 07:16:09 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AAF92DF6; Mon, 17 Dec 2012 07:16:09 +0000 (UTC) (envelope-from mr.kodiak@gmail.com) Received: from mail-ia0-f182.google.com (mail-ia0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 4EB7C8FC14; Mon, 17 Dec 2012 07:16:09 +0000 (UTC) Received: by mail-ia0-f182.google.com with SMTP id x2so5046170iad.13 for ; Sun, 16 Dec 2012 23:16:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=bP2afdEn3yowvQUmMkbDIaIewlN3Ys/gKZNzRyY2pEs=; b=tmrlr8t4g3OkSNmZXfhkr7A/yaSdkSsMYdGbc1Mel7ril4qSBtWwala3PySJ9JaO7h IfDj/O1iR1n/SF15iM+019rYS4uiJ1z/cFbYyDg5tc6AN+wsLzU+5r0XCg1qp1YxqFk7 lfb4saO+vsXWG9mBRZRDG1D8c4MTiT1BYwWQSPT6X4HZhAOqbvhSnWGODdKJU9OXkWFf aNOc56xgGz6hZRaZ16beELJ7S9kRdw516b0HW8wEHok/giHRhbj7AzSs6PRx78dCdrBP 9gHX3C7rKMUVCFTAs0Dp5CvebUYH8X4kZjO/0o1BSE5hiekf3aQJHh9SifFmTUrM9YMi sg9g== Received: by 10.50.33.147 with SMTP id r19mr8246780igi.73.1355728568735; Sun, 16 Dec 2012 23:16:08 -0800 (PST) MIME-Version: 1.0 Sender: mr.kodiak@gmail.com Received: by 10.64.41.133 with HTTP; Sun, 16 Dec 2012 23:15:38 -0800 (PST) In-Reply-To: References: From: Bryan Venteicher Date: Mon, 17 Dec 2012 01:15:38 -0600 X-Google-Sender-Auth: wOTGi0DaRy-Jyiw_eUssiHTTHds Message-ID: Subject: Re: VirtIO in GENERIC To: Andrew Thompson Content-Type: text/plain; charset=ISO-8859-1 X-Mailman-Approved-At: Mon, 17 Dec 2012 13:44:23 +0000 Cc: Jim Harris , freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2012 07:16:09 -0000 On Mon, Dec 17, 2012 at 12:06 AM, Andrew Thompson wrote: > On 17 December 2012 18:06, Jim Harris wrote: >> >> >> >> On Sun, Dec 16, 2012 at 6:53 PM, Andrew Thompson >> wrote: >>> >>> On 17 December 2012 13:17, Bryan Venteicher wrote: >>> >>> > There's been lots of requests to have VirtIO in GENERIC for i386 and >>> > amd64. Anybody have any issues or concerns with this or the patch at >>> > [1]. This also removes the kludge that was introduced in r239009. >>> > >>> > I've compiled LINT for i386 and amd64 so hopefully there won't be any >>> > surprise breakages. >>> > >>> > [1] http://people.freebsd.org/~bryanv/patches/virtio.generic.patch >>> >>> >>> It would be great to have the drivers enabled. You do not need the >>> sys/conf/files changes, the common and arch files are combined. >>> >> >> Removing the virtio files from sys/conf/files ensures these drivers can >> only be specified in x86 kernel configuration files. r239009 added these >> lines to sys/conf/files, but Bryan's patch does it more correctly. > > Yes, I think the patch is correct for what I intended - support for x86 only (for now). > Linux supports virtio on ARM so I dont think its necessarily x86 MD. I guess > it can be moved back later. > I think VirtIO on ARM (on QEMU) effectively requires VirtIO-MMIO, which we don't support yet. And virtio_pci is probably missing some bus_space_barriers() required for non-x86. Both are on my TODO, but nobody has prodded me about either yet. > > Andrew