From owner-p4-projects@FreeBSD.ORG Mon Jul 25 21:30:29 2005 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 84CAC16A421; Mon, 25 Jul 2005 21:30:28 +0000 (GMT) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4945716A41F for ; Mon, 25 Jul 2005 21:30:28 +0000 (GMT) (envelope-from soc-victor@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E24A243D4C for ; Mon, 25 Jul 2005 21:30:27 +0000 (GMT) (envelope-from soc-victor@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j6PLURrW064811 for ; Mon, 25 Jul 2005 21:30:27 GMT (envelope-from soc-victor@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j6PLURu7064806 for perforce@freebsd.org; Mon, 25 Jul 2005 21:30:27 GMT (envelope-from soc-victor@freebsd.org) Date: Mon, 25 Jul 2005 21:30:27 GMT Message-Id: <200507252130.j6PLURu7064806@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to soc-victor@freebsd.org using -f From: Victor Cruceru To: Perforce Change Reviews Cc: Subject: PERFORCE change 80987 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2005 21:30:29 -0000 http://perforce.freebsd.org/chv.cgi?CH=80987 Change 80987 by soc-victor@soc-victor_82.76.158.176 on 2005/07/25 21:29:50 A matter of style: use the special purpose (already defined) oid_zeroDotZero variable instead hardcoded values all over the HOST RESOURCES code. Affected files ... .. //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_device_tbl.c#4 edit .. //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c#2 edit .. //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_swrun_tbl.c#5 edit Differences ... ==== //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_device_tbl.c#4 (text+ko) ==== @@ -225,7 +225,7 @@ } - entry->id = (struct asn_oid){2,{0,0,}}; /*unknown id - FIX ME*/ + entry->id = oid_zeroDotZero; /*unknown id - FIX ME*/ entry->status = hrDevice_getStatus(dev); ==== //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c#2 (text+ko) ==== @@ -174,7 +174,7 @@ entry->load = 0; entry->cpu_no = (u_char)cpu_no; entry->idle_pid = 0; - entry->frwId = (struct asn_oid){2,{0,0,}}; /*unknown id - FIX ME*/ + entry->frwId = oid_zeroDotZero; /*unknown id - FIX ME*/ INSERT_OBJECT_INT(entry, &hrState_g.hr_processor_tbl); hrState_g.detected_processor_count++; ==== //depot/projects/soc2005/bsnmp/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_swrun_tbl.c#5 (text+ko) ==== @@ -159,7 +159,7 @@ entry->name[sizeof(entry->name) - 1] = '\0'; (void)strncpy(&entry->name[0], &kp->ki_ocomm[0], sizeof(entry->name) - 1); - entry->id = (struct asn_oid){2,{0,0,}}; /*unknown id - FIX ME*/ + entry->id = oid_zeroDotZero; /*unknown id - FIX ME*/ entry->path[0] = '\0'; entry->parameters[0] = '\0'; @@ -224,7 +224,7 @@ /*no parameters for kernel files (.ko) of for the kernel*/ entry->parameters[0] = '\0'; - entry->id = (struct asn_oid){2,{0,0,}}; /*unknown id - FIX ME*/ + entry->id = oid_zeroDotZero; /*unknown id - FIX ME*/ if (strncmp(kfs->name, "kernel", strlen("kernel") ) == 0) { entry->type = SRT_OPERATING_SYSTEM;