From owner-svn-src-head@freebsd.org Fri Dec 23 00:05:14 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84A57C8B058 for ; Fri, 23 Dec 2016 00:05:14 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 178D2103D for ; Fri, 23 Dec 2016 00:05:13 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f66.google.com with SMTP id t196so1405761lff.3 for ; Thu, 22 Dec 2016 16:05:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=uCvqWoD+F0lkfVLjtRrrGW05TVbuaf6p2UDwhJdSnJQ=; b=pkf9JJD7mHGbNwuHssdAhQTJJT+uZK3dlDZsmmaZgpAIc1qbCMjFR1jSxcErUpTeXU hhHKmoLIDgF9gipX6WPH2KZ9unUYSEyrgCK4dfY2+1AO4Y6ttqZMa7KNj2iaThQgEcDu ++KsYs5k+D3Y/HpT6cm3wmMnXVfKF/G8rkJkRDdkox8k+9FArnVxEQROI/cRkrGIS+A4 IoAZ+xGoXqLUOdg48fwqM0IGY7zKIgm/6eyado77mUs5dv+WtJ7+ufdQShrSpbgfyPba aFMKMUzrdiwBXvojv3QB+FlyTRKWsWeQX87ngEkMioVUbC3EzEn7dSWBcfcZIX1JUFyj 3m0A== X-Gm-Message-State: AIkVDXL0WNDHF69D6JtYLHpWSaVfvPvX5gsRqK19PgF9pwmM6u8N+7IAws59klap4ATxNw== X-Received: by 10.46.74.10 with SMTP id x10mr5195152lja.8.1482451505724; Thu, 22 Dec 2016 16:05:05 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id p9sm556125lfd.49.2016.12.22.16.05.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2016 16:05:05 -0800 (PST) Subject: Re: svn commit: r310433 - head/lib/libc/stdio To: cem@freebsd.org, Ngie Cooper References: <201612222230.uBMMUge9075128@repo.freebsd.org> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Andrey Chernov Message-ID: Date: Fri, 23 Dec 2016 03:05:04 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 00:05:14 -0000 On 23.12.2016 1:39, Conrad Meyer wrote: > This was unjustified and inappropriate. I don't think so. While being able to back it out or fix it by another way by yourself, you just doing nothing for several days. Your personal reasons of inability to act properly so long time weights less than project consistency at whole, so backing it out from anybody is justified and appropriate in such situations. > On Thu, Dec 22, 2016 at 2:30 PM, Ngie Cooper wrote: >> Author: ngie >> Date: Thu Dec 22 22:30:42 2016 >> New Revision: 310433 >> URL: https://svnweb.freebsd.org/changeset/base/310433 >> >> Log: >> Revert r310138 >> >> Adding %b support to vfprintf for parity with kernel space requires >> more discussion/review. >> >> In particular, many parties were concerned over introducing a >> non-standard format qualifier to *printf(3) which didn't already >> exist in other OSes, e.g. Linux, thus making code which used %b >> harder to port to other operating systems. >> >> Requested by: many >> >> Modified: >> head/lib/libc/stdio/vfprintf.c >> >> Modified: head/lib/libc/stdio/vfprintf.c >> ============================================================================== >> --- head/lib/libc/stdio/vfprintf.c Thu Dec 22 21:56:41 2016 (r310432) >> +++ head/lib/libc/stdio/vfprintf.c Thu Dec 22 22:30:42 2016 (r310433) >> @@ -611,37 +611,6 @@ reswitch: switch (ch) { >> case 'z': >> flags |= SIZET; >> goto rflag; >> - case 'b': >> - { >> - const char *q; >> - int anybitset, bit; >> - >> - ulval = (u_int)GETARG(int); >> - cp = GETARG(char *); >> - >> - q = __ultoa(ulval, buf + BUF, *cp++, 0, xdigs_lower); >> - PRINT(q, buf + BUF - q); >> - >> - if (ulval == 0) >> - break; >> - >> - for (anybitset = 0; *cp;) { >> - bit = *cp++; >> - if (ulval & (1 << (bit - 1))) { >> - PRINT(anybitset ? "," : "<", 1); >> - q = cp; >> - for (; (bit = *cp) > ' '; ++cp) >> - continue; >> - PRINT(q, cp - q); >> - anybitset = 1; >> - } else >> - for (; *cp > ' '; ++cp) >> - continue; >> - } >> - if (anybitset) >> - PRINT(">", 1); >> - } >> - continue; >> case 'C': >> flags |= LONGINT; >> /*FALLTHROUGH*/ >> >