Date: Tue, 27 Dec 2022 20:15:36 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 526f57bf85a2 - main - Update CWARNFLAGS in bsd.sys.mk and CWARNEXTRA in kern.mk for clang 15. Message-ID: <5AA0B3E0-4F11-4F8C-8950-028A59BB2955@FreeBSD.org> In-Reply-To: <5a772eb7-55c8-5e73-e346-5514ef144dc3@FreeBSD.org> References: <202212251159.2BPBxmAG029954@gitrepo.freebsd.org> <5a772eb7-55c8-5e73-e346-5514ef144dc3@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_AC5C7F6F-B79A-4C2C-BD28-CDD346408558 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 27 Dec 2022, at 18:40, John Baldwin <jhb@freebsd.org> wrote: >=20 > On 12/25/22 3:59 AM, Dimitry Andric wrote: >> The branch main has been updated by dim: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D526f57bf85a2b9b113c55ded47b932ab= c8567bc5 >> commit 526f57bf85a2b9b113c55ded47b932abc8567bc5 >> Author: Dimitry Andric <dim@FreeBSD.org> >> AuthorDate: 2022-07-25 10:29:58 +0000 >> Commit: Dimitry Andric <dim@FreeBSD.org> >> CommitDate: 2022-12-25 11:58:22 +0000 >> Update CWARNFLAGS in bsd.sys.mk and CWARNEXTRA in kern.mk for = clang 15. >> MFC after: 3 days >> --- >> share/mk/bsd.sys.mk | 17 +++++++++++++++-- >> sys/conf/kern.mk | 4 ++++ >> 2 files changed, 19 insertions(+), 2 deletions(-) >> diff --git a/share/mk/bsd.sys.mk b/share/mk/bsd.sys.mk >> index a220c9d173ed..43359fed29c7 100644 >> --- a/share/mk/bsd.sys.mk >> +++ b/share/mk/bsd.sys.mk >> @@ -86,6 +94,11 @@ CWARNFLAGS.clang+=3D -Wno-unused-const-variable >> .if ${COMPILER_TYPE} =3D=3D "clang" && ${COMPILER_VERSION} >=3D = 130000 >> CWARNFLAGS.clang+=3D -Wno-error=3Dunused-but-set-variable >> .endif >> +.if ${COMPILER_TYPE} =3D=3D "clang" && ${COMPILER_VERSION} >=3D = 150000 >> +CWARNFLAGS.clang+=3D -Wno-error=3Darray-parameter >=20 > I've fixed all these that GCC 12 finds. Do we really need to disable = it for clang > now after I've pushed those recent fixes? I didn't notice, but it's likely because I had the above in the llvm-15-update branch for months now. I found some old build logs from the beginning of December, and they still contained ~20 of these warnings. But if they're all fixed now then sure, lets's remove the -Wno-error=3D again. >> +CWARNFLAGS.clang+=3D -Wno-error=3Ddeprecated-non-prototype >=20 > I'm curious how many places are broken by this and how much it would = be to fix? > This is just adding '(void)' in place of '()', yes? 5859 instances, as of the last count. I committed a bunch of these, and then got some negative feedback about it, so I decided to simply make the warning non-fatal. Somebody else can go over these one by one and fix them as drive-by commits. Indeed the fix is just replacing () in declarations and definitions of C functions with (void). -Dimitry --Apple-Mail=_AC5C7F6F-B79A-4C2C-BD28-CDD346408558 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCY6tEWQAKCRCwXqMKLiCW owEXAKDZx2NV5xDi63O8xmMICDj3fAFJngCfRj1BWWx0a/Mf/HUj7fZFIrYMTCY= =Ef/H -----END PGP SIGNATURE----- --Apple-Mail=_AC5C7F6F-B79A-4C2C-BD28-CDD346408558--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5AA0B3E0-4F11-4F8C-8950-028A59BB2955>