From owner-svn-src-head@freebsd.org Thu Aug 27 16:04:09 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A5C203B72F7; Thu, 27 Aug 2020 16:04:09 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BcnbX4306z3bGS; Thu, 27 Aug 2020 16:04:08 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pg1-f171.google.com with SMTP id 67so3665742pgd.12; Thu, 27 Aug 2020 09:04:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1rSIm+AXrArXxigZp1X+VBLdH6WpfjWS8T4eqHRvCqM=; b=BIJaLXQDm8kbmv/NSuWLe5IYV9tD38T5FHr0uLtTYxM6nDhoMfV2TPsqV0vSD1iknw ZAIm3ChQSmM09fZMMYpPU/OXesnRgw4zKX8bQurwEBNOzweLRkuwgoBrnK4ll2as3AzU QxzxrRUXF6y97Y4+L3U+nnDHqUxIb1AkK27W81x27IyqfaFkvfA5tyEqHd8LQae0daed kv27Fadqcv9cVmemczRtLCKWOeZILQjIsb4LRqUeaTNLuLp1TtMKI+uJrXkW1wNwPXYg GEvfPG11CG36v+IRVQlUWP4RwfptzCjPnhIo3MXrTu8WgNoNKbM4v74aQgpLdUCFvb2V uhSA== X-Gm-Message-State: AOAM533ImL5MRumqOOxzfZA4a3FvBSb99k5Gv/0acHyes4TWU2Am3kgM R/TG88mjTcqjd5zJsA15ModU+XuK3mc= X-Google-Smtp-Source: ABdhPJwQN2/GWSaMlCBWVIKaBBeKR3mfGIyNcdYyJGacrQuaiTngPjs5AjM2G0hM7nVK5rx+ONaPUg== X-Received: by 2002:a17:902:d681:: with SMTP id v1mr3131361ply.34.1598544246290; Thu, 27 Aug 2020 09:04:06 -0700 (PDT) Received: from [192.168.0.135] ([195.64.148.76]) by smtp.googlemail.com with ESMTPSA id w3sm3452519pff.56.2020.08.27.09.04.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2020 09:04:05 -0700 (PDT) Subject: Re: svn commit: r364817 - head/libexec/rc/rc.d To: Cy Schubert Cc: Cy Schubert , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <202008261313.07QDDwRm040119@repo.freebsd.org> <7e55d429-482b-2277-b340-2b85c687440e@FreeBSD.org> <202008271350.07RDoGqn055838@slippy.cwsent.com> <202008271354.07RDsTeW084744@slippy.cwsent.com> From: Andriy Gapon Autocrypt: addr=avg@FreeBSD.org; prefer-encrypt=mutual; keydata= mDMEXxhZ/BYJKwYBBAHaRw8BAQdAcr09MGWggRAy8POEInH6mCbjrO8kgtRyHbst99gQlvy0 HkFuZHJpeSBHYXBvbiA8YXZnQEZyZWVCU0Qub3JnPoiWBBMWCAA+FiEE+nF8afRo79+kdvKg LcuxURQbv/YFAl8YWfwCGwMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLcux URQbv/b/ngD/cTPdaKXZ8O1KzZ6BwqHuoJEL4qIjT3MiiovorL7WisABALU4NV3jAKu9hgSc Wl1QVjQ1NpzbY5gsMxZbuRlHwfAJuDgEXxhZ/BIKKwYBBAGXVQEFAQEHQKws2uTFgRunZ2Ip 1OYj0+cJOObFTfEDDI9hh2Fed7pFAwEIB4h+BBgWCAAmFiEE+nF8afRo79+kdvKgLcuxURQb v/YFAl8YWfwCGwwFCQlmAYAACgkQLcuxURQbv/apxgD/f6ml+zRTb/uB6zO/e4RS2S+V+rGf CTw551MKSZmkp1sA/2QbLsnmeHrsIPvY5Wn97BMmMQsDu+fxMSagSbSMa7YJ Message-ID: <66b4c241-a06e-4f91-f979-c87db45d5435@FreeBSD.org> Date: Thu, 27 Aug 2020 19:04:04 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <202008271354.07RDsTeW084744@slippy.cwsent.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BcnbX4306z3bGS X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-1.56 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.87)[-0.870]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.72)[-0.715]; NEURAL_SPAM_LONG(0.02)[0.025]; RCVD_IN_DNSWL_NONE(0.00)[209.85.215.171:from]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.215.171:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MAILMAN_DEST(0.00)[svn-src-head,svn-src-all] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 16:04:09 -0000 On 2020-08-27 16:54, Cy Schubert wrote: > In message <202008271350.07RDoGqn055838@slippy.cwsent.com>, Cy Schubert > writes: >> In message <7e55d429-482b-2277-b340-2b85c687440e@FreeBSD.org>, Andriy Gapon >> wri >> tes: >>> On 26/08/2020 16:13, Cy Schubert wrote: >>>> Author: cy >>>> Date: Wed Aug 26 13:13:57 2020 >>>> New Revision: 364817 >>>> URL: https://svnweb.freebsd.org/changeset/base/364817 >>>> >>>> Log: >>>> As of r364746 (OpenZFS import) existing ZPOOLs are not imported >>>> prior to zvol and mountcritlocal resulting in ZVOLs (swap and >>> >>> I probably missed some discussion, so I am curious why that is. >> >> This is because r364746 added the code below to rc.d/zfs and by then it was >> too late. I simply moved it to a new file that allowed rc.d/zvol and >> rc.d/mountcritlocal with legacy mounts to work again. This was copied from >> rc.d/zfs, which was added by r364746. There was no need for a zpool import >> under the previous version of ZFS, whereas it appears that OpenZFS requires >> it. > > Let me add, one could say this is a regression. Yes, I was actually curious about this change in ZFS driver behavior. -- Andriy Gapon