From owner-freebsd-ports@FreeBSD.ORG  Tue Aug 25 18:06:20 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AEB05106568C;
	Tue, 25 Aug 2009 18:06:20 +0000 (UTC) (envelope-from oberman@es.net)
Received: from mailgw.es.net (mail1.es.net [IPv6:2001:400:201:1::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 9736B8FC0C;
	Tue, 25 Aug 2009 18:06:20 +0000 (UTC)
Received: from ptavv.es.net (ptavv.es.net [IPv6:2001:400:910::29])
	by mailgw.es.net (8.14.3/8.14.3) with ESMTP id n7PI6IFc014273
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Tue, 25 Aug 2009 11:06:20 -0700
Received: from ptavv.es.net (ptavv.es.net [127.0.0.1])
	by ptavv.es.net (Tachyon Server) with ESMTP id BD0331CC09;
	Tue, 25 Aug 2009 11:06:18 -0700 (PDT)
To: ahze@freebsd.org
Date: Tue, 25 Aug 2009 11:06:18 -0700
From: "Kevin Oberman" <oberman@es.net>
Message-Id: <20090825180618.BD0331CC09@ptavv.es.net>
X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5, 1.2.40,
	4.0.166 definitions=2009-08-25_05:2009-08-11, 2009-08-25,
	2009-08-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
	ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam
	adjust=0 reason=mlx engine=5.0.0-0907200000
	definitions=main-0908250122
Cc: ports@freebsd.org
Subject: serpentine port forces dependency on muine
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Aug 2009 18:06:20 -0000

I have been trying to remove all dependencies on the broken muine port
and discovered that an error in the serpentine port Makefile causes
serpentine to always depend on muine.

The Makefile uses the config option MUINE to indicate whether to build
the muine plugin, but the script then checks "WITH_MUINE" and always
build the muine plugin and creates a dependency on muine.

I have opened PR ports/138179.

I patched the Makefile with:
--- sysutils/serpentine/Makefile.orig	2009-08-25 10:45:24.000000000 -0700
+++ sysutils/serpentine/Makefile	2009-08-25 10:07:00.000000000 -0700
@@ -29,7 +29,7 @@
 
 .include <bsd.port.pre.mk>
 
-.if (defined(WITH_MUINE) || exists(${LOCALBASE}/bin/muine)) && ${ARCH}=="i386"
+.if (defined(MUINE) || exists(${LOCALBASE}/bin/muine)) && ${ARCH}=="i386"
 BUILD_DEPENDS+=	muine:${PORTSDIR}/audio/muine
 RUN_DEPENDS+=	muine:${PORTSDIR}/audio/muine
 PLIST_SUB+=	MUINE=""

This may not be the best way as it overloads the MUINE variable
differently than it is now overloaded, but it looks like it is logically
correct.

The obvious alternative is to add:
.if defined(MUINE)
WITH_MUINE=	yes
.endif
-- 
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman@es.net			Phone: +1 510 486-8634
Key fingerprint:059B 2DDF 031C 9BA3 14A4  EADA 927D EBB3 987B 3751