From owner-svn-src-head@freebsd.org Thu May 5 00:47:24 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BE3AB2C315; Thu, 5 May 2016 00:47:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22a.google.com (mail-pf0-x22a.google.com [IPv6:2607:f8b0:400e:c00::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3DD3C147B; Thu, 5 May 2016 00:47:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22a.google.com with SMTP id 206so31274401pfu.0; Wed, 04 May 2016 17:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6BmUkWt6c2LIfMPZDk4sXw+TyNLPofGfDMI3fUvmSjI=; b=YA9x/gzFLSc/OJiJQ8NCfbGYpUTGOfBEySydmT+R/Wk2e6qzDGDFLMQKWjVxf3mqoL RP5ew3T5O7Dg9oMwrpfkGmFOENqRI6DI8ZcGrl4JwgWMqxsviLzadAGOpWIZOBjasrvA CW7wGZdYiFsBTTFswtQ0ydbOQJPArD1u4fDxKp8BtTGgq6IyN65nWON3k3d1O/er4GH4 IubqeJEzsKQKcZAXIUrzcZKVP5o7ztriZNiUk2osHwNIkNwPDDFUZ1Rne+xEnbzYimL2 JQK5nQ+ew6NaQuOqtslHU84vdl44lRnKa6FNfEmBjdyEMEO0uRbO8WwZxOHu3JAWXoFS stlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6BmUkWt6c2LIfMPZDk4sXw+TyNLPofGfDMI3fUvmSjI=; b=k8eVp5AZMYe9HFgynre6EqBHjn24QLameA0hFT42GDbGNoEcY1UwZo7QMNCOQ8sK8P dRp7WJSMmYSFFzM9c6PdK2o+Z06fy1LDkA4DFWzhM/6UxnO5ToTCzVJ3E7euZv/+lbXu P5yHQ+Rb0DXcZr4nctqxtBSszovg0i865h8h712/soj2u7IDl3pIAFBJRkwbwCB3HpD1 5ZA2PbuFFWO8fgO2tCaxcf23YGeTgidE6yENzPbDqK3/38nVWpehKCvvMaMK8R+KBySQ 8IDSbniPs+MIwuvy5mGTcg1OQ5MEuKOHEhod316cceLIAff5gUm0MySog6joU/kyePo1 L4tQ== X-Gm-Message-State: AOPr4FUgLM1DP1qjZCX7DgGdMngVflaFTBJ2awZebuWqctMOnYRiNHQ9hnPkkx3G8o/pwg== X-Received: by 10.98.69.132 with SMTP id n4mr16252169pfi.53.1462409243079; Wed, 04 May 2016 17:47:23 -0700 (PDT) Received: from [192.168.100.137] ([199.231.240.59]) by smtp.gmail.com with ESMTPSA id u127sm8733111pfb.82.2016.05.04.17.47.21 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 04 May 2016 17:47:22 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r299086 - head From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <20160505003135.GH1369@FreeBSD.org> Date: Wed, 4 May 2016 17:47:20 -0700 Cc: Garrett Cooper , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <07EA9409-1155-4D47-BD81-D03C675A35CE@gmail.com> References: <201605042100.u44L0fdS023680@repo.freebsd.org> <3C136183-85D6-4047-8F2B-FB1B6C310AFF@gmail.com> <20160505003135.GH1369@FreeBSD.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 00:47:24 -0000 > On May 4, 2016, at 17:31, Gleb Smirnoff wrote: >=20 > On Wed, May 04, 2016 at 02:06:33PM -0700, Ngie Cooper (yaneurabeya) = wrote: > N>=20 > N> > On May 4, 2016, at 14:00, Garrett Cooper = wrote: > N> >=20 > N> > Author: ngie > N> > Date: Wed May 4 21:00:41 2016 > N> > New Revision: 299086 > N> > URL: https://svnweb.freebsd.org/changeset/base/299086 > N> >=20 > N> > Log: > N> > Default NO_INSTALLEXTRAKERNELS to "no" to unbreak the build > N> >=20 > N> > MFC after: soon (was insta-MFCed -_-..) > N> > Pointyhat to: glebius > N> > Sponsored by: EMC / Isilon Storage Division > N> >=20 > N> > Modified: > N> > head/Makefile.inc1 >=20 > Defaulting it to "no" you changed the behaviour backwards, which is > wrong. Agreed. That=E2=80=99s why I inverted it back to =E2=80=9Cyes=E2=80=9D = in r299088. > N> This broke for me on 11.0-CURRENT because I use: > N>=20 > N> KERNCONFS=3D GENERIC GENERIC-NODEBUG > N>=20 > N> and use installkernel with INSTKERNNAME. >=20 > That's quite specific setup. Probably NO_INSTALLEXTRAKERNELS should > be played with conditionally. It=E2=80=99s not an uncommon setup though. I have used it on all my = CURRENT machines for some time because I might want to be able to use = INVARIANTS kernels sometimes when doing kernel changes, and boot = !INVARIANTS kernels all of the time. I chose "?=3D yes=E2=80=9D because it=E2=80=99s better syntactic sugar = than `defined(NO_INSTALLEXTRAKERNELS) && ${NO_INSTALLKERNELS} !=3D = =E2=80=9Cyes=E2=80=9D` and it works with pre-bmake (the other idiom that = bmake allows that would work here=E2=80=A6 although with more duplicity = is `:Uyes`, which would break installkernel on FreeBSD 9 machines or = with fmake as the system make). Thanks! -Ngie=