From owner-p4-projects@FreeBSD.ORG  Fri Aug 15 09:44:28 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3EFDE1065672; Fri, 15 Aug 2008 09:44:28 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 030D61065670
	for <perforce@freebsd.org>; Fri, 15 Aug 2008 09:44:28 +0000 (UTC)
	(envelope-from trasz@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id D75BD8FC1F
	for <perforce@freebsd.org>; Fri, 15 Aug 2008 09:44:27 +0000 (UTC)
	(envelope-from trasz@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7F9iRBf057149
	for <perforce@freebsd.org>; Fri, 15 Aug 2008 09:44:27 GMT
	(envelope-from trasz@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7F9iRuE057147
	for perforce@freebsd.org; Fri, 15 Aug 2008 09:44:27 GMT
	(envelope-from trasz@freebsd.org)
Date: Fri, 15 Aug 2008 09:44:27 GMT
Message-Id: <200808150944.m7F9iRuE057147@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	trasz@freebsd.org using -f
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 147431 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Aug 2008 09:44:28 -0000

http://perforce.freebsd.org/chv.cgi?CH=147431

Change 147431 by trasz@trasz_traszkan on 2008/08/15 09:43:38

	Don't silently ignore "-d" flag in getfacl(1); warn instead.

Affected files ...

.. //depot/projects/soc2008/trasz_nfs4acl/bin/getfacl/getfacl.c#11 edit

Differences ...

==== //depot/projects/soc2008/trasz_nfs4acl/bin/getfacl/getfacl.c#11 (text+ko) ====

@@ -197,8 +197,15 @@
 	else
 		more_than_one++;
 
-	if (pathconf(path, _PC_EXTENDED_SECURITY_NP))
+	if (pathconf(path, _PC_EXTENDED_SECURITY_NP)) {
+		if (type == ACL_TYPE_DEFAULT) {
+			warnx("%s: there are no default entries in NFS4 ACLs",
+				path);
+			return (-1);
+		}
+
 		type = ACL_TYPE_NFS4;
+	}
 
 	if (!qflag)
 		printf("# file: %s\n# owner: %s\n# group: %s\n", path,