From owner-freebsd-bugs@FreeBSD.ORG  Sat Feb 16 14:20:02 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7C29D16A41B
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 16 Feb 2008 14:20:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 7090E13C4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 16 Feb 2008 14:20:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m1GEK2dd014193
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 16 Feb 2008 14:20:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m1GEK2fv014192;
	Sat, 16 Feb 2008 14:20:02 GMT (envelope-from gnats)
Date: Sat, 16 Feb 2008 14:20:02 GMT
Message-Id: <200802161420.m1GEK2fv014192@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Antoine Brodin <antoine@FreeBSD.org>
Cc: 
Subject: Re: kern/68905: core dumps are assigned wrong ownership
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Antoine Brodin <antoine@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Feb 2008 14:20:02 -0000

The following reply was made to PR kern/68905; it has been noted by GNATS.

From: Antoine Brodin <antoine@FreeBSD.org>
To: bug-followup@FreeBSD.org, trew@hick.org
Cc:  
Subject: Re: kern/68905: core dumps are assigned wrong ownership
Date: Sat, 16 Feb 2008 14:44:19 +0100

 This is a multi-part message in MIME format.
 
 --Multipart=_Sat__16_Feb_2008_14_44_19_+0100_qDxOlQLAvZKL=+NR
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 Here is a patch, not much tested and obtained from OpenBSD.
 
 --Multipart=_Sat__16_Feb_2008_14_44_19_+0100_qDxOlQLAvZKL=+NR
 Content-Type: text/x-diff;
  name="kern-sig.diff"
 Content-Disposition: attachment;
  filename="kern-sig.diff"
 Content-Transfer-Encoding: 7bit
 
 Index: kern_sig.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/kern/kern_sig.c,v
 retrieving revision 1.355
 diff -u -p -r1.355 kern_sig.c
 --- kern_sig.c	13 Jan 2008 14:44:09 -0000	1.355
 +++ kern_sig.c	14 Jan 2008 13:32:06 -0000
 @@ -3110,9 +3110,14 @@ restart:
  	NDFREE(&nd, NDF_ONLY_PNBUF);
  	vp = nd.ni_vp;
  
 -	/* Don't dump to non-regular files or files with links. */
 +	/*
 +	 * Don't dump to non-regular files, files with links or files
 +	 * owned by someone else.
 +	 */
  	if (vp->v_type != VREG ||
 -	    VOP_GETATTR(vp, &vattr, cred, td) || vattr.va_nlink != 1) {
 +	    VOP_GETATTR(vp, &vattr, cred, td) || vattr.va_nlink != 1 ||
 +	    vattr.va_mode & (S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH) ||
 +	    vattr.va_uid != cred->cr_uid) {
  		VOP_UNLOCK(vp, 0);
  		error = EFAULT;
  		goto close;
 
 
 --Multipart=_Sat__16_Feb_2008_14_44_19_+0100_qDxOlQLAvZKL=+NR--