From owner-svn-src-all@freebsd.org Thu Mar 17 04:05:04 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A567AD3E48; Thu, 17 Mar 2016 04:05:04 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0117.outbound.protection.outlook.com [157.56.111.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 62687A96; Thu, 17 Mar 2016 04:05:02 +0000 (UTC) (envelope-from sjg@juniper.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=junipernetworks.onmicrosoft.com; s=selector1-juniper-net; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Kf2JcbjN9sWjW7srI7cCabNXNaEO/KbXdUW46W0GKdk=; b=Jg8SBQ0kCeUOESu6ytqQUeD3qzahDsx4c1ZykXnT/nK03hgkxkMt9lHGqfyAQwY2tbp/0Z3VOapzc5FjFYQSw1c60+xiC5grA0WzyXYjPCG3aYvijupczhgvtdj8bD6KqpkrtiuwYbqDD2q0sjMHh8SawUCU3UcDyRNkWgcn6f0= Received: from BY1PR0501CA0017.namprd05.prod.outlook.com (10.162.139.27) by SN1PR0501MB2125.namprd05.prod.outlook.com (10.163.228.152) with Microsoft SMTP Server (TLS) id 15.1.434.16; Thu, 17 Mar 2016 04:05:00 +0000 Received: from BN1BFFO11FD018.protection.gbl (2a01:111:f400:7c10::1:194) by BY1PR0501CA0017.outlook.office365.com (2a01:111:e400:4821::27) with Microsoft SMTP Server (TLS) id 15.1.443.12 via Frontend Transport; Thu, 17 Mar 2016 04:05:00 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.19) smtp.mailfrom=juniper.net; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.19 as permitted sender) Received: from p-emfe01b-sac.jnpr.net (66.129.239.19) by BN1BFFO11FD018.mail.protection.outlook.com (10.58.144.81) with Microsoft SMTP Server (TLS) id 15.1.434.11 via Frontend Transport; Thu, 17 Mar 2016 04:04:59 +0000 Received: from magenta.juniper.net (172.17.27.123) by p-emfe01b-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 16 Mar 2016 21:04:58 -0700 Received: from kaos.jnpr.net (kaos.jnpr.net [172.21.16.84]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id u2H44vD69950; Wed, 16 Mar 2016 21:04:57 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id AF9CD385508; Wed, 16 Mar 2016 21:04:57 -0700 (PDT) To: NGie Cooper CC: , , , Subject: Re: svn commit: r296970 - head/lib/libxo/tests In-Reply-To: <984878F0-9CE9-442D-8F7F-40C5365052AA@gmail.com> References: <201603170037.u2H0b4Rb082849@repo.freebsd.org> <984878F0-9CE9-442D-8F7F-40C5365052AA@gmail.com> Comments: In-reply-to: NGie Cooper message dated "Wed, 16 Mar 2016 19:47:02 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <85788.1458187497.1@kaos.jnpr.net> Date: Wed, 16 Mar 2016 21:04:57 -0700 Message-ID: <85789.1458187497@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:66.129.239.19; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(199003)(24454002)(52314003)(189002)(50466002)(5003600100002)(81166005)(4001430100002)(87936001)(50986999)(86362001)(76176999)(19580395003)(19580405001)(97756001)(76506005)(106466001)(53416004)(117636001)(47776003)(2906002)(6806005)(46406003)(1411001)(105596002)(4326007)(5008740100001)(92566002)(11100500001)(110136002)(1220700001)(189998001)(1096002)(23726003)(77096005)(2950100001)(586003)(107886002)(50226001)(2810700001)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:SN1PR0501MB2125; H:p-emfe01b-sac.jnpr.net; FPR:; SPF:SoftFail; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD018; 1:jGAlsi4qRhE4hmxA442GZLdsP5zTT3I/GiES++tJIS2YHscrMYghMT3JNlchz1no3pjI3fMgNFvKtO9Jii6vAVnxrsQJBZ9k7ZcM1PAKWhyWZuUyL1az8wYula1ofAhYfA+5bmAA0QandI0BtjQ2iswjf1eJBnB+8uhc7zRz4LEP8aL46mr+/5XBdW/79KI0hBqnVuV/4oSIDk7l65gCpao0Sez+rMxUgeD24yLuPvs7FW7kfmkFhfj7tnhji/m0jgOMOrsO6Cf0mOTGdEjBcc8P1ME/Zby7Ah8QNVYxvUvL/scRvYzYyw5dqUFn+D7KX3W1H0ANfCiVKuS4wXYqldiPV0fqczNOqZeETD7Lsu5yw9nbM2fVpgS5hHimOqDXT7c8usQAD88VqxN9/PjwwDrRnvjZ6jZ3HSbvu1Rfe22hC5826KP2vO7hZU9494XnU6GnXIfnqYUYmyPMhQLcWSdftpyDOhS/fW8TgScKFX4= X-MS-Office365-Filtering-Correlation-Id: 4ff06d02-6d19-413b-0e1a-08d34e194f2b X-Microsoft-Exchange-Diagnostics: 1; SN1PR0501MB2125; 2:yF4l+XEHs8iF8erXAq36Quv3SXKBhVJJzWH+hutNisGfqMw9/cQvKIDTcexNuonvqX1pMO40/vk2U0R5Mq3EV7QtuJfE0JcZrhrO/aJ9GsmI5TixdIOMJHjTXbkTCr2+jvqB92s5odD1EXx9YgZov3YQZ2ebfuPwlzaxptakIpakbKOlcBmwwjjYEl2ZI3mE; 3:hqreuCQLRSfaWEL4hg0f7cT4k/l2vXgRKJtYJDk82XlLa3hjZ+hwc90IpSDocwWY/WIWYcGloO0m0Ug6XLsnFAbDrhVWVDOW2X4doEu8uGpn8W9pjUvDv8na7JP1FO86p9VTUHcwUwf5xZuKGe3T3QmWUltvc8Yu+ASezxwOPkwGLHdyxWbVYo4J2ee+3RcDy7KqK5WunXI2XLScW4ijZPeVg9K/tQFg692U0NOGztM=; 25:Cg3p4SnpESVcl/5pm+DFMbjU6jUkWj3VCDPtLwYjzeRzJfxS5tS14pcqN2rHlKrQ++A/ITnfR5W/iCtpYBCu9CFuPXAr3/MseezC/wvqASLfN4TGv1lfr4L9tSAKDLEFi0M9YZ4M90ZwiHvU31r5W5UzCYNi6/fgz9J779qp4E7cqSRCY1xKOPZ79W+Q/zbUFj1weJyqFGNcBJ9Z3TfPTlYp4YzcctonCfpiGR9/hn0/FHnU1DbceamodsJCYYXieJEQ8TpaPrz7NNm2E9urSab9W3uUgfot/d2rq1DvPcjpOOI/IOtLwsQaWcgh7tb3AaMfJ9HiggxmeQwpXxhegA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0501MB2125; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0501MB2125; 20:WZK/2RjdDad60s6pRTH7x9Pz64K8lPUEtytHT7Eiwxj0l/oiEbtHAcV7g/5o7gyp83cDSvUXPCjclRnU2DnB8yNQ2X0YRIRGJ14sjUx9UwWIjuGlwhTByEdOMsbB0xwBbIr5T2/uQ3nClEs0J5Hw8YA6DIlrViRLLlDdBuAoNQPukchz6aaNXW/GfZCLo8eBTrUQ1L5FlDYtlh4EcODHJsp5aMc5RYNRLWtrm77QBLtYZpqbuJ8ctPcx5W3sm1ds2BamFo9a8FqiAyyarJ0x2LTTN+k5IOk7QP5dfojO09MuEjpN7irwezbY1LvUknvzic4T2nzVth9/Yk1TvthNtoKxGgo9RvUxfx7svqXi8wLyxxkYcfC1WyPGxXUBaJ+vpOzZE2WR8KildiUYEzEizXcVocs2vaAVQYBt3xpdb1k2xGTenxbidyhhTqQ+5qaQfYlOu5p8VCo/FZrm/DAKZtgUp2s2aYxU0wdQnUjeqHMtqcQbNgR7lnU76sGG1lN4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13017025)(13015025)(5005006)(13023025)(13024025)(13018025)(8121501046)(3002001)(10201501046); SRVR:SN1PR0501MB2125; BCL:0; PCL:0; RULEID:; SRVR:SN1PR0501MB2125; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0501MB2125; 4:jJCjWBDl3+Iven11hof5gLFy2mOURDrQHG/RT2EUKdtKB8NjA8qfPIOKtFSstYeOPJPhfKYG9xGuzxFMuFHjNC4BsyMifE4/T36AZmr/+pdgS+6RVbtyd5uz5aw9lllfO7fBZ4jgQp3+YDJ+xhjuQ00E6XY7vAZflWsC6hxlNvf/oRsVmxTuoQJNQKmcLDpNfDrkIuI6fRQfmccCwDrYmF7IBrfzviGUr4PUHYuNNm2S2OaLIxt7DrPtZHAffjcQG+zSEm50wnKAkZliQdPuOKh2lCowpftGp0373mkk/E0uScj+9HHXecRDa1tww4B3ar8lPO5iclYszDbW6kvrjis1HbzyCwx/Uf/i19Amk05lzsMcJNUYhJVtNDfrCpVRbptVq5GZTgR82Ev9/UbalbSKQ5TLMkAV1XAcLYvdMKhmS4YjKBhUb6zcnLb3xZh2M/pqANSm5xn7eYPNWF2lvA== X-Forefront-PRVS: 0884AAA693 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0501MB2125; 23:/W1CQAQruRhmhh1l44UGzl3TOJzwu4tasekhmY/?= =?us-ascii?Q?CjM293NBJGgyBsXDLuIJ6s6Zjpj8I6Pym3Rv1ZTEaiCuSwenIzpQeg3O99Dd?= =?us-ascii?Q?TiH1x0GhedB463wvXkFja20cBpzwKAbn+CHigYNch3GuylHmp0fZxvAB8RZ/?= =?us-ascii?Q?02HEcD1YayvpN1KTCNye+N1B4f/OCsc3z2pOL4Vs4wJuIAIDo6d1h3ZsQIL9?= =?us-ascii?Q?MAZfBeE7kgRyVOJKhLartPY1ykZ9b0NB33oZllkmsxH54Q6HW4heDoQ/p3cg?= =?us-ascii?Q?J2lYe6w8Qfz6jvFRMC2/Yvmbgzr4W8xnbYGreU/lHChoazH7Gc3aETkPSl37?= =?us-ascii?Q?VEYvElKTg1qjO3TN+NwjJswSluA58ubog5zFGc40vNuWx60DdT8oB99x7sEw?= =?us-ascii?Q?n755edd+RrmjGsoPENIpI6tK0yym+GyCQI8bN40wuFXj89cDDvL1Xc8dAno0?= =?us-ascii?Q?FUs9ncebUAT6L27YKyhjFEWyy/USR8dJ3scWFHcyQx+nhmP04fHOcKLSAuMC?= =?us-ascii?Q?IfDY1cwSX5yyZJHt0qAN8FCO7OPs9tMALqkPhDvlZA5iBD6eYo0cHnX6OmZq?= =?us-ascii?Q?k7/ODZgTKt3Efgqg/b3Y/T238BDgBwmb8FhiW8yzql8VuaV3+txWexpmAWNc?= =?us-ascii?Q?+vzkZQ38YaugW6DJWkIifRsNtjB4G9d7rctFLW3L+DCMdsQdBMwX/ZOCzIdH?= =?us-ascii?Q?RK1fcY9+YANKe29QWxEva6uD7vPtwRFUosjdVIhbktFuYFxFlUUcsA9cjPfq?= =?us-ascii?Q?OS4dCnMFY/jlAFGi4AeCSAWXKy7zA0UwmcbAmv+b1jwJCYhf12BQxXVE6QX9?= =?us-ascii?Q?KQ8CsUj37pj4BcFA4y6K37xzTIjFORjjGpuNxZ3Doa+lgA+AtDbrqAuprz3w?= =?us-ascii?Q?m97PHHBG9Ut+itRWUmxkIqsoH9NEoatqqHhBm7pHe5QxfV0YnkPfJeiekhxE?= =?us-ascii?Q?Qw+tbxKpORXnN46t8OJnbDT8V8r61rYGHLPvDg4/fKgW+fZXHzdHJeL40Vjk?= =?us-ascii?Q?PqytYzt5L0Jm92Z03QG+62cPO/elyfDW8VqF8+Cd/2tiIbcbc4cw3WbU0bJd?= =?us-ascii?Q?TnfZOOaiiXxK5jqhOPkq6f5efHV+Qcx4bsOnjcYDbLdyAUqhbykS7RAwaXyc?= =?us-ascii?Q?opEJSabX5lng=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0501MB2125; 5:bR297MuZlRrZiibjNtTKRTegK2FOlCKlxN9N3XUgY8HHAkPpSBO3m42eNZzhV2jZSNVc8QOQlxyelPJGmY+qyWTp5HY+KnYG1DLMXQLmeq6JQRh4bhb3G+e8+hGmN9KUdMjYUKGLnv/LlZRn5XWMYQ==; 24:9cAjOrHPlBbjNSZE20A8wRELUISsJOriJmapJTz/kBd8oh0OUcV5ONQMblAGZzLxBwGy6T3cjHm6OA7/8nRJoo5g9X37lLMhL/XUUyEU1Uo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2016 04:04:59.5154 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.19]; Helo=[p-emfe01b-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0501MB2125 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2016 04:05:04 -0000 NGie Cooper wrote: > > SUBDIR+= encoder > > > > +.if ${MACHINE} == "host" > > +# make it easy to test without install > > +TESTSDIR= ${.OBJDIR} > > +CFLAGS+= -I${.CURDIR:H} > > +.endif > > + > > .include > > This commit seems unnecessary -- have you tried make check yet? That appears to require installing things before you test that they work - seems a bit backwards? Note the above is only relevant when building with DIRDEPS. Where we want to be able to build and run relevant tests as part of the build as we go - when MACHINE = "host" that is. Phil wants to fix this so that it runs all his test suite properly and also need to arrange to auto-update the makefile here as new tests are added to the distribution. Probably need somthing like bmake's after-import target. Anyway, being able to have this work in context of DIRDEPS_BUILD will help (I haven't added the MK_TESTS hooks yet).