From owner-cvs-all@FreeBSD.ORG  Wed Feb 15 15:46:31 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.ORG
Delivered-To: cvs-all@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0ED2A16A422;
	Wed, 15 Feb 2006 15:46:31 +0000 (GMT)
	(envelope-from emaste@phaedrus.sandvine.ca)
Received: from mailserver.sandvine.com (sandvine.com [199.243.201.138])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8C1A343D46;
	Wed, 15 Feb 2006 15:46:30 +0000 (GMT)
	(envelope-from emaste@phaedrus.sandvine.ca)
Received: from labgw2.phaedrus.sandvine.com ([192.168.3.11]) by
	mailserver.sandvine.com with Microsoft SMTPSVC(6.0.3790.1830); 
	Wed, 15 Feb 2006 10:44:53 -0500
Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 12627)
	id 0CAFF1365B; Wed, 15 Feb 2006 10:46:29 -0500 (EST)
Date: Wed, 15 Feb 2006 10:46:28 -0500
From: Ed Maste <emaste@phaedrus.sandvine.ca>
To: Ruslan Ermilov <ru@FreeBSD.ORG>
Message-ID: <20060215154628.GA94447@sandvine.com>
References: <200602151345.k1FDj2Aq013830@repoman.freebsd.org>
	<20060215151508.GC96442@ip.net.ua>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060215151508.GC96442@ip.net.ua>
User-Agent: Mutt/1.4.2.1i
X-OriginalArrivalTime: 15 Feb 2006 15:44:53.0859 (UTC)
	FILETIME=[C3AC5B30:01C63246]
Cc: cvs-src@FreeBSD.ORG, Gleb Smirnoff <glebius@FreeBSD.ORG>,
	src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/dev/em if_em.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Feb 2006 15:46:31 -0000

On Wed, Feb 15, 2006 at 05:15:09PM +0200, Ruslan Ermilov wrote:

> On Wed, Feb 15, 2006 at 01:45:02PM +0000, Gleb Smirnoff wrote:
> > glebius     2006-02-15 13:45:02 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/dev/em           if_em.c 
> >   Log:
> >   em_hardware_init() in em_init() is not needed, and leads to annoying
> >   link flap.
> >   
> >   Submitted by:   ru, Mike Tancsa
> >   
> >   Revision  Changes    Path
> >   1.112     +0 -7      src/sys/dev/em/if_em.c
> > 
> Hmm, I have abandoned this change locally, as it was causing me
> some problems I cannot fully recall now.  Perhaps it was *NOT*
> reprogramming the receive filter on a MAC change, I don't
> remember.

I discovered that on 5.4 also (the rx filter not being written
on a MAC addr change).  When I looked into it a while back it
appeared that the behaviour would be no different on HEAD.

-ed