From owner-svn-src-all@FreeBSD.ORG Wed Oct 8 20:39:34 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CE38D5E4; Wed, 8 Oct 2014 20:39:34 +0000 (UTC) Received: from mail-wi0-x232.google.com (mail-wi0-x232.google.com [IPv6:2a00:1450:400c:c05::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E95319F0; Wed, 8 Oct 2014 20:39:33 +0000 (UTC) Received: by mail-wi0-f178.google.com with SMTP id cc10so122224wib.17 for ; Wed, 08 Oct 2014 13:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=A/cmEIIN9uSSAbZoahZZJ54c30lq1TZqJ314iTFoeuA=; b=XYESd6ZspHlC0IlQEXSibxq4Aii7PBoW0sGOAEljhCfJhh+UqXAiUb51CO9NC6XB5E UUaPsoH2Rt3bIcffa8zIMCSnnJfPqCTwp6B5iCyX7rxEwtWp6d9VfONxnzWP5aQa+w2+ N+0/zXkVa504NS7h6RJ63D/4P6IxXsMjVt0i5wHa86QTokPPI63Cqgh3uKIYA+S5d7zo 8Otoy4OTjqzlQhcQkgvFR2tuB64d3EqPjmdI9GPJlZxj05fOWIPIpL1Pohe73y10ar8R Jdib6iPeMAWOidBctDY6vg0TraZM9emXlteFsw/d1zPbnJX8aMdHfgbyvKeHteqmumOx G3rg== X-Received: by 10.180.87.161 with SMTP id az1mr36297863wib.13.1412800772033; Wed, 08 Oct 2014 13:39:32 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id bv17sm1801670wib.13.2014.10.08.13.39.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Oct 2014 13:39:31 -0700 (PDT) Sender: Baptiste Daroussin Date: Wed, 8 Oct 2014 22:39:29 +0200 From: Baptiste Daroussin To: Craig Rodrigues Subject: Re: svn commit: r272649 - head/contrib/byacc Message-ID: <20141008203928.GA2675@ivaldir.etoilebsd.net> References: <201410061443.s96Eh2Jn022718@svn.freebsd.org> <20141006144924.GB37670@ivaldir.etoilebsd.net> <20141007223941.GT37670@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Oct 2014 20:39:35 -0000 --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 08, 2014 at 01:10:19PM -0700, Craig Rodrigues wrote: > On Tue, Oct 7, 2014 at 3:39 PM, Baptiste Daroussin wro= te: >=20 > > On Tue, Oct 07, 2014 at 02:02:34PM -0700, Craig Rodrigues wrote: > > > On Mon, Oct 6, 2014 at 7:49 AM, Baptiste Daroussin > > wrote: > > > > > > > > > > > Why a direct commit instead of a proper import of 20141005 version?= it > > > > would > > > > have imho been better, simpler and easier to maintain. > > > > > > > > > > Because according to Thomas Dickey, he did not fix all > > > the memory related problems in snapshot 20141005. Specifically there= are > > > still > > > some issues not fixed when realloc() is called. > > > I was going to wait for the next snapshot. > > > However, I wanted to get that one fix into FreeBSD to fix the kyua te= sts, > > > which have been failing under Jenkins. See: > > > https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-tests2/ > > > (see runs #10 and #11). > > > > In that case I will import the new one which has the fix (do you confir= m?) > > >=20 > According to http://invisible-island.net/byacc/CHANGES.html , the > 2014-10-06 has a fix > to address my concerns. However, this fix involves a lot of changes to t= he > code, > and I don't have time right now to audit everything. >=20 > There have been a lot of changes to the byacc code in the past few days. > The changes > are good bugfixes, but I would recommend auditing everything beore > importing the snapshot into FreeBSD. It has already been imported the only difference between the version in base since 2 days ago and the version upstream now is your change. regards, Bapt --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlQ1oQAACgkQ8kTtMUmk6EwlMgCfT7LDln4+rPctQbGewkV2eHLU qXoAoKLb8JXa6qOQ7QAikrnWbd6fzTkM =LImK -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--