From owner-svn-ports-all@freebsd.org  Tue Oct 30 09:28:54 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5CD1B10DCA4A;
 Tue, 30 Oct 2018 09:28:54 +0000 (UTC)
 (envelope-from hans@beastielabs.net)
Received: from atlas.fritz.box (unknown
 [IPv6:2001:985:87e:1:20d:b9ff:fe42:685c])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "atlas", Issuer "atlas" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id E4B5A79B19;
 Tue, 30 Oct 2018 09:28:53 +0000 (UTC)
 (envelope-from hans@beastielabs.net)
Received: from beastie.fritz.box (beastie.fritz.box [192.168.66.176])
 by atlas.fritz.box (8.15.2/8.15.2) with ESMTP id w9U9SqCm051774;
 Tue, 30 Oct 2018 10:28:52 +0100 (CET)
 (envelope-from hans@beastielabs.net)
Subject: Re: svn commit: r483437 - in head/mail/dovecot: . files
To: Larry Rosenman <ler@FreeBSD.org>
References: <201810292328.w9TNSRHm018030@repo.freebsd.org>
From: Hans Ottevanger <hans@beastielabs.net>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Message-ID: <7ff427eb-0dbc-bc82-0485-9fefcfd62a5e@beastielabs.net>
Date: Tue, 30 Oct 2018 10:28:52 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <201810292328.w9TNSRHm018030@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2018 09:28:54 -0000

On 10/30/18 12:28 AM, Larry Rosenman wrote:
> Author: ler
> Date: Mon Oct 29 23:28:26 2018
> New Revision: 483437
> URL: https://svnweb.freebsd.org/changeset/ports/483437
> 
> Log:
>    mail/dovecot: give better error message(s) when there are configuration errors.
>    
>    PR:		232785
>    Submitted by:	prj@rootwyrm.com
> 
> Modified:
>    head/mail/dovecot/Makefile
>    head/mail/dovecot/files/dovecot.in
> 
> Modified: head/mail/dovecot/Makefile
> ==============================================================================
> --- head/mail/dovecot/Makefile	Mon Oct 29 23:25:58 2018	(r483436)
> +++ head/mail/dovecot/Makefile	Mon Oct 29 23:28:26 2018	(r483437)
> @@ -8,7 +8,7 @@
>   
>   PORTNAME=	dovecot
>   PORTVERSION=	2.3.3
> -PORTREVISION=	2
> +PORTREVISION=	3
>   CATEGORIES=	mail ipv6
>   MASTER_SITES=	https://www.dovecot.org/releases/2.3/
>   
> 
> Modified: head/mail/dovecot/files/dovecot.in
> ==============================================================================
> --- head/mail/dovecot/files/dovecot.in	Mon Oct 29 23:25:58 2018	(r483436)
> +++ head/mail/dovecot/files/dovecot.in	Mon Oct 29 23:28:26 2018	(r483437)
> @@ -60,6 +60,14 @@ for config in ${dovecot_config}; do
>   	required_files="${config}"
>   	command_args="-c ${config}"
>   	if [ -s ${config} ]; then
> +               ${command} ${command_args} -a 2>/dev/null
> +                if [ $? -ne 0 ]; then
> +                       echo "==Error=="
> +                       echo "Configuration file check failed."
> +                       # Use dovecot to print the config error.
> +                       ${command} ${command_args} -a
> +                       exit $?
> +                fi
>   		base_dir=$(${command} ${command_args} -a 2>/dev/null | /usr/bin/awk -F '= ' '/^base_dir =/ { print $2 }')
>   		pidfile="${base_dir}/master.pid"
>   	else
> _______________________________________________
> svn-ports-all@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-ports-all
> To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
> 

Hi,

This change causes every invocation of /usr/local/etc/rc.d/dovecot to 
unnecessarily spit out the configuration info to stdout . This can be 
prevented by also redirecting stdout, i.e. adding ">/dev/null" in the 
first added line.

Kind regards,

Hans Ottevanger