From owner-freebsd-scsi@FreeBSD.ORG  Sat Sep 20 21:39:50 2003
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0DD0716A4B3; Sat, 20 Sep 2003 21:39:50 -0700 (PDT)
Received: from panzer.kdm.org (panzer.kdm.org [216.160.178.169])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BA23A43FE3; Sat, 20 Sep 2003 21:39:46 -0700 (PDT)
	(envelope-from ken@panzer.kdm.org)
Received: from panzer.kdm.org (localhost [127.0.0.1])
	by panzer.kdm.org (8.12.9/8.12.5) with ESMTP id h8L4dg64022900;
	Sat, 20 Sep 2003 22:39:42 -0600 (MDT)
	(envelope-from ken@panzer.kdm.org)
Received: (from ken@localhost)
	by panzer.kdm.org (8.12.9/8.12.5/Submit) id h8L4dgsU022899;
	Sat, 20 Sep 2003 22:39:42 -0600 (MDT)
	(envelope-from ken)
Date: Sat, 20 Sep 2003 22:39:42 -0600
From: "Kenneth D. Merry" <ken@kdm.org>
To: Thomas Quinot <thomas@FreeBSD.ORG>
Message-ID: <20030921043942.GB22790@panzer.kdm.org>
References: <20030920110131.GA41062@melusine.cuivre.fr.eu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030920110131.GA41062@melusine.cuivre.fr.eu.org>
User-Agent: Mutt/1.4.1i
cc: freebsd-scsi@FreeBSD.ORG
cc: gibbs@FreeBSD.ORG
Subject: Re: Missing length specification in scsi_request_sense
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Sep 2003 04:39:50 -0000

On Sat, Sep 20, 2003 at 13:01:31 +0200, Thomas Quinot wrote:
> The CDB built by scsi_request_sense always has a zero length indication,
> preventing correct transfer of sense data during recovery action by
> cam_periph. The following change resolves the problem, please review.
> 
> Thomas.
> 
> Index: scsi/scsi_all.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/cam/scsi/scsi_all.c,v
> retrieving revision 1.42
> diff -u -r1.42 scsi_all.c
> --- scsi/scsi_all.c	10 Jun 2003 18:14:04 -0000	1.42
> +++ scsi/scsi_all.c	20 Sep 2003 10:53:38 -0000
> @@ -2408,6 +2408,7 @@
>  	scsi_cmd = (struct scsi_request_sense *)&csio->cdb_io.cdb_bytes;
>  	bzero(scsi_cmd, sizeof(*scsi_cmd));
>  	scsi_cmd->opcode = REQUEST_SENSE;
> +	scsi_cmd->length = dxfer_len;
>  }
>  
>  void

Looks good, please commit.

Ken
-- 
Kenneth Merry
ken@kdm.org