From owner-svn-src-all@freebsd.org Thu Apr 14 08:32:22 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC007B0F498; Thu, 14 Apr 2016 08:32:22 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from kif.fubar.geek.nz (kif.fubar.geek.nz [178.62.119.249]) by mx1.freebsd.org (Postfix) with ESMTP id AC7141EA6; Thu, 14 Apr 2016 08:32:22 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from zapp (97e174ce.skybroadband.com [151.225.116.206]) by kif.fubar.geek.nz (Postfix) with ESMTPSA id DED06D7A17; Thu, 14 Apr 2016 08:22:30 +0000 (UTC) Date: Thu, 14 Apr 2016 09:22:29 +0100 From: Andrew Turner To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297954 - in head/sys: boot/efi/loader/arch/amd64 boot/i386/libi386 x86/acpica Message-ID: <20160414092229.1ba8d6c5@zapp> In-Reply-To: <201604140459.u3E4xpYv038183@repo.freebsd.org> References: <201604140459.u3E4xpYv038183@repo.freebsd.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2016 08:32:23 -0000 On Thu, 14 Apr 2016 04:59:51 +0000 (UTC) Warner Losh wrote: > Author: imp > Date: Thu Apr 14 04:59:51 2016 > New Revision: 297954 > URL: https://svnweb.freebsd.org/changeset/base/297954 > > Log: > Deprecate using hints.acpi.0.rsdp to communicate the RSDP to the > system. This uses the hints mechnanism. This mostly works today > because when there's no static hints (the default), this value can > be fetched from the hint. When there is a static hints file, the hint > passed from the boot loader to the kernel is ignored, but for the > BIOS case we're able to find it anyway. However, with UEFI, the > fallback doesn't work, so we get a panic instead. > > Switch to acpi.rsdp and use TUNABLE_ULONG_FETCH instead. Continue to > generate the old values to allow for transitions. In addition, fall > back to the old method if the new method isn't present. > > Add comments about all this. > > Differential Revision: https://reviews.freebsd.org/D5866 Why not pass it in using module data as we do with the DTB? It would fix issues where we have either or both static hints and a stat env. Whatever method is decided we will also need it on arm64 as we claim to support ACPI there, although no backwards compatibility will be needed as the code is most likely broken as it's only partially been tested. Andrew