From owner-svn-src-all@freebsd.org Thu Nov 23 09:53:30 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24B93DE63D6; Thu, 23 Nov 2017 09:53:30 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CEF396479F; Thu, 23 Nov 2017 09:53:27 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 38caca44; Thu, 23 Nov 2017 10:53:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=07/3bk8AZAZNmjHsc6zPm4JB3PI=; b=jh02H4ydgsrcMoPjVeyoqy8jOEy4 l5tg9si4jByByA8KJJD7UM2Mbn/Tv6GSTSHg26glnGHL70Z3vuSnltqFo+bkj/PG I5r2GkSmuFsNw0WQp83MwnvMtdZyFZ+7pf3QoyBLv0M/NBAgv6AN9hIl/Q0XDFYD a46ftp2dr5kZXLw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=kgJ80gRWbtie3P1FZGC6CPtiVwasTR6IsEP+VzVKWNiepkhDs6JKH6z5 cTc8pGban0j6WPSYKdyyeZ2xq/WQbluoGvwLIDKF8cXJuQBapOE2jHQZpGRyEkQI HZN7wAay6xaIB+TK1k2RWQt4wNIqVaAPJCazcNX1PCSt3K/0G0k= Received: from arcadia (evadot.gandi.net [217.70.181.36]) by mail.blih.net (OpenSMTPD) with ESMTPSA id dbd3411f TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Thu, 23 Nov 2017 10:53:24 +0100 (CET) Date: Thu, 23 Nov 2017 10:53:24 +0100 From: Emmanuel Vadot To: Devin Teske Cc: Ian Lepore , Emmanuel Vadot , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, owner-src-committers@freebsd.org Subject: Re: svn commit: r326095 - head/usr.sbin/bsdinstall/scripts Message-Id: <20171123105324.8726e4e5c0471f87ea9c4089@bidouilliste.com> In-Reply-To: <821D3401-1DA8-46B5-BF5C-AAC3BDA3D8F3@shxd.cx> References: <201711221527.vAMFRlTc041361@repo.freebsd.org> <1511368688.46031.1.camel@freebsd.org> <821D3401-1DA8-46B5-BF5C-AAC3BDA3D8F3@shxd.cx> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 09:53:30 -0000 Hi Devin, On Thu, 23 Nov 2017 01:33:39 -0800 Devin Teske wrote: > > > > On Nov 22, 2017, at 11:15 PM, Emmanuel Vadot wrote: > > > >> On 2017-11-22 17:38, Ian Lepore wrote: > >>> On Wed, 2017-11-22 at 15:27 +0000, Emmanuel Vadot wrote: > >>> Author: manu > >>> Date: Wed Nov 22 15:27:47 2017 > >>> New Revision: 326095 > >>> URL: https://svnweb.freebsd.org/changeset/base/326095 > >>> Log: > >>> bsdinstall: Add ntpdate option > >>> > >>> When you install a computer for the first time, the date in the CMOS sometimes > >>> not accurate and you need to ntpdate as ntpd will fail a the time difference > >>> is too big. > >>> Add an option in bsdinstall to enable ntpdate that will do that for us. > >>> > >>> Reviewed by: allanjude > >>> Differential Revision: https://reviews.freebsd.org/D13149 > >>> Modified: > >>> head/usr.sbin/bsdinstall/scripts/services > >>> Modified: head/usr.sbin/bsdinstall/scripts/services > >>> ============================================================================== > >>> --- head/usr.sbin/bsdinstall/scripts/services Wed Nov 22 15:18:11 2017 (r326094) > >>> +++ head/usr.sbin/bsdinstall/scripts/services Wed Nov 22 15:27:47 2017 (r326095) > >>> @@ -46,6 +46,8 @@ DAEMONS=$( dialog --backtitle "FreeBSD Installer" \ > >>> local_unbound "Local caching validating resolver" ${local_unbound:-off} \ > >>> sshd "Secure shell daemon" ${sshd_enable:-off} \ > >>> moused "PS/2 mouse pointer on console" ${moused_enable:-off} \ > >>> + ntpdate "Synchronize system and network time at bootime" \ > >>> + ${ntpdate_enable:-off} \ > >>> ntpd "Synchronize system and network time" ${ntpd_enable:-off} \ > >>> powerd "Adjust CPU frequency dynamically if supported" \ > >>> ${powerd_enable:-off} \ > >> The right way to enable a time-step at boot is to set the rc conf > >> variable ntpd_sync_on_start to YES. ntpdate has been deprecated for > >> *years*. > >> -- Ian > > > > Hi Ian, > > > > Thanks I didn't know about option -g (nor ntpd_sync_on_start), this bring a few questions : > > > > - Is there any reason to not always use -g for ntpd ? As a lambda user I just want my time to be set, no matter what. > > - Should we remove ntpdate in -current before 12 if it's deprecated ? > > > > I'll make the necessary changes according to your (or others) answers. > > > > I would not remove ntpdate. > > Is there a way to make ntpd sync and then quit immediately? Just by reading the man I see the -q option which does exactly that. Setting both -q and -g should have the same behavior than ntpdate (not tested). > If not, sounds like ntpdate serves a purpose not filled by ntpd. > > Valid case is someone running a VM that gets paused for days, weeks, or even months at a time. On such a VM it may make more sense to let the clock be only sporadically managed in an adhoc manner. > > I personally like to use ntpdate on said VMs because I generally set a timeout on my ssh-agent in said VMs and by managing the clock manually allows me to better control keys loaded. > > Pretty sure other people may have other reasons for non-daemonized clock management. That's why I asked :) > -- > Devin -- Emmanuel Vadot