From owner-freebsd-hackers@freebsd.org Fri Mar 25 07:47:39 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 497C3ADC7A4; Fri, 25 Mar 2016 07:47:39 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D4E471388; Fri, 25 Mar 2016 07:47:38 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x230.google.com with SMTP id l68so11746173wml.0; Fri, 25 Mar 2016 00:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TkO5CpTynLZVbl+BNAmaaREiU9HHVUXsExB9Zvq9RGk=; b=ZjfAEfrDJMb2wchswuQkOJDKsb0YxW8JRjyiehKt2aElgKHtN1T6qOLaiaBIJb69SL iVZb2FE39jtDWx2r+s0+2qTyMkHkjL5GD6VY34ols7aVxZ+KQ/nQ/AeBl69ft391fmkp md1FV8/siwSElbsmMPng8mMOa/+3QXgDclXfbbbnj18C/LzcebyZhiAaFQFQARrN1zPF ncD2/DE9C1pobjRMXasIhn1AMcbo4QXmNRrUEr5IT5iDqAfAxC12IapVTQaQyJch4hSZ HRc1+1N39l0WcHYOgV+x7tpTP8cu0sR7u1jyUgczyFqcppD+FuTS60R9hTE9QZgxcDxx 5guQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=TkO5CpTynLZVbl+BNAmaaREiU9HHVUXsExB9Zvq9RGk=; b=K8yj2fjXMWA44AnZ1K8eDCGVlGA3Frkz/JjP+IzQyFbBjPfTRbDxEdT5mKOU4tB2An 9HXsUR0vh1KxmPKBQsEe9PfQW37wz7lyUib5lp+5O5oUx9hMtwV0u0mtdGK7nqMaCrp1 YwmmcUucYCKlmKGnG5yH0nYGxD4Ig5Sm1i10KwqFadx9IopYzbiCppwKlfxb6DppG4yt j+pjhnqelH41QVDfJE/sRdyofXGko4UQgqgFk5ZlvM+f1JkMorE7ZqZcKjB04a0xBOjN jzoXlW2ejxWTLCUEmTLgAEMWkeX1xSvmcB+i/4JubiWclTGmTPU7hkh3p+L/RQ5DTmuv z3cw== X-Gm-Message-State: AD7BkJK9BetOBnHXNILX52o5SnU1OYl1Mlz3QCGO+etHUcsd7WVlfehQPX7aF2JE/kA9OQ== X-Received: by 10.194.23.67 with SMTP id k3mr13259244wjf.177.1458892057282; Fri, 25 Mar 2016 00:47:37 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id v2sm1956949wmd.24.2016.03.25.00.47.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Mar 2016 00:47:35 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 25 Mar 2016 08:47:33 +0100 From: Baptiste Daroussin To: Bryan Drewery Cc: Pietro Cerutti , Matthew Seaman , freebsd-hackers@freebsd.org, owner-freebsd-hackers@freebsd.org Subject: Re: Code Formatter for STYLE(9)? Message-ID: <20160325074733.GA36953@ivaldir.etoilebsd.net> References: <56F3EBB1.1060603@embedded-brains.de> <56F3FFB3.6070801@FreeBSD.org> <1fc0f5efcc94822f7f5ca9bbcb850faf@gahr.ch> <56F48322.9030208@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: <56F48322.9030208@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2016 07:47:39 -0000 --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 24, 2016 at 05:15:30PM -0700, Bryan Drewery wrote: > On 3/24/2016 9:24 AM, Pietro Cerutti wrote: > > On 2016-03-24 15:54, Matthew Seaman wrote: > >> On 2016/03/24 13:29, Sebastian Huber wrote: > >>> Hello, > >>> > >>> is there a ready to use C code formatter available that honours > >>> STYLE(9)? I tried clang-format, but it knows only LLVM, Google, > >>> Chromium, Mozilla by default. The GNU indent --original seems to prod= uce > >>> nothing usable. Same problem with astyle --style=3Dbsd. > >>> > >> > >> pkg uses uncrustify with this config file: > >> > >> https://github.com/freebsd/pkg/blob/master/freebsd.cfg > >> > >> It's approximately what style(9) describes but doesn't cover things li= ke > >> sorting include files and I don't think it was updated in response to > >> the recent change allowing { brackets } around certain single-line > >> statements. > >=20 > > It looks like it does: https://github.com/freebsd/pkg/commit/1bc61a4 > >=20 >=20 > It's not quite right. It is adding {} to single-line if statements in > some code. Yes this is un purpose for pkg >=20 > > static __inline struct filemon * > > filemon_acquire(struct filemon *filemon) > > { > > - > > - if (filemon !=3D NULL) > > + if (filemon !=3D NULL) { > > refcount_acquire(&filemon->refcnt); > > + } > > return (filemon); > > } >=20 > It's also not aware of our (silly?) blank line with no declarations rule: I couldn't find how to make that >=20 > > static __inline void > > filemon_drop(struct filemon *filemon) > > { > > - > > sx_xunlock(&filemon->lock); > > filemon_release(filemon); > > } >=20 > And wrapping multiple conditions: >=20 > > - if (p->p_filemon !=3D NULL && p !=3D curproc) > > + if ((p->p_filemon !=3D NULL) && (p !=3D curproc)) { > > return (EBUSY); > > + } Same I couldn't find how to make that better >=20 > It's also not respecting the wrap rule of tabs + 4 spaces. same >=20 > It's also adding random blank lines before functions and macros. yup The above reasons are why it has not been automatically used in pkg. It is the closer I could get, I would be happy to get patches to improve Best regards, Bapt --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW9O0PAAoJEGOJi9zxtz5aRoEP/Rg8W8woYQ+qkchAV8QOVX3B uSgqNqV03kmOT5ZvSGpwgKx4LWTZOnn2WglZiCGtflL+TkuYyVhw8D2hxznRgmsu zsJakqkEGARRmW6GA/H7x3B+SEMUVGiV9IHEamGhtUEEtw2k+3Cn5jRFFny3JI3T nGbgceEFewlhnDg1sco8VZIk9eFVE5Lbp72FPtW5AmOm2tN6XN4neUwj/SBT6QGl Hykgrn+WYyV9k7J3OMqpX0HUQ/f+LZGl9oX7yGBKJ4R9SaImLvaSvVtIZoquRvok ct/dFojkc5+wtb6bc48I3Kgu2EsOYg2rn91Q8t1ITvs6uCjrh5HxuWcbdoNx4wcr BF5ewkilcGZE7yhFsfQJfoQCQ5HHoUGs+1/LVO7YCg2EGxTQJe3984hbqVacB72i FqgIFstYh97gJWsdmPHgsLL7c+LX3oqdpC/fSOtQnZPIPcP2hnzB109mXZV7WfLz Pfy22W1BLuxWMYZd4SD4qsmBYB1apyj9nK9dJOknsT/AJ93ALe2BXemHeFnHRNso ezIak10QKEwDxpw02H33enwC3vH7DwQT+W+HEZjrAoUep9KuZbly5SqWwVUTleVA OyxUPknmeyorpmj0kW3B6YriCgr16hx42RiH0AMwgkpXyXCjG9QPtTECZ1il1kDL 2Roq+EKfDD2+n5aVZpWW =Wmj1 -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--