Date: Sat, 06 Aug 2016 11:34:35 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 211623] [PATCH] Mk/Scripts/do-fetch fails when DISTDIR is symlink Message-ID: <bug-211623-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211623 Bug ID: 211623 Summary: [PATCH] Mk/Scripts/do-fetch fails when DISTDIR is symlink Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: bugzilla.freebsd@omnilan.de CC: freebsd-ports-bugs@FreeBSD.org Keywords: patch Created attachment 173355 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D173355&action= =3Dedit Patch do-fetch.sh to do mkdir DISTDIR only if onexistant In do-fetch.sh, there's a unconditional 'mkdir -p "${dp_DISTDIR}"' This doesn't work if ${DISTDIR} exists and is a symbolic link. I'm not aware of problems with DISTDIR beeing a symlink, so here's a patch which only does 'mkdir' if DISTDIR doesn't exist at all =E2=80=93 no checks= for read/write permissions suitable at that point, nor if the link is dead. Further check's shouldn't be affected, if there are any in place (long time= ago I included own Makefiles doing such checks because they were missing at that time =E2=80=93 haven't checked if that changed during the last 5 years) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211623-13>