From nobody Fri Sep 10 23:28:22 2021
X-Original-To: git@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 49AB317C13E1
	for <git@mlmmj.nyi.freebsd.org>; Fri, 10 Sep 2021 23:28:24 +0000 (UTC)
	(envelope-from jhb@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4H5sWD1VFVz3mTW;
	Fri, 10 Sep 2021 23:28:24 +0000 (UTC)
	(envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(Client did not present a certificate)
	(Authenticated sender: jhb)
	by smtp.freebsd.org (Postfix) with ESMTPSA id C25DC6F39;
	Fri, 10 Sep 2021 23:28:23 +0000 (UTC)
	(envelope-from jhb@FreeBSD.org)
Subject: Re: git: 3b96abbab033 - main - make: fix MAKE_JOB_ERROR_TOKEN
To: Warner Losh <imp@bsdimp.com>
Cc: git@freebsd.org
References: <202109102011.18AKBsb3022349@gitrepo.freebsd.org>
 <3ea29521-42f0-614b-0b0a-4ade132a9c9d@FreeBSD.org>
 <CANCZdfrs1dDLu_e=d04MvaaGMtnr2v+F=FPDXHuwH6-kmEXPDg@mail.gmail.com>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <b49b582a-4538-3c10-b6a7-26b8a34689a2@FreeBSD.org>
Date: Fri, 10 Sep 2021 16:28:22 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
List-Id: Discussion of git use in the FreeBSD project <freebsd-git.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-git
List-Help: <mailto:freebsd-git+help@freebsd.org>
List-Post: <mailto:freebsd-git@freebsd.org>
List-Subscribe: <mailto:freebsd-git+subscribe@freebsd.org>
List-Unsubscribe: <mailto:freebsd-git+unsubscribe@freebsd.org>
Sender: owner-freebsd-git@freebsd.org
MIME-Version: 1.0
In-Reply-To: <CANCZdfrs1dDLu_e=d04MvaaGMtnr2v+F=FPDXHuwH6-kmEXPDg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ThisMailContainsUnwantedMimeParts: N

On 9/10/21 4:10 PM, Warner Losh wrote:
> Hey John,
> 
> On Fri, Sep 10, 2021 at 4:30 PM John Baldwin <jhb@freebsd.org> wrote:
> 
>> Do the pre-push hooks check for log messages containing the template?  It
>> might be nice to reject pushes that add commits with the template in the
>> log message to help catch accidents.
>>
> 
> I thought git did this automatically...

Clearly nothing blocked this push. :)

-- 
John Baldwin