Date: Mon, 23 Aug 2021 15:32:57 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 258006] www/grafana8: Update to 8.1.2 Message-ID: <bug-258006-7788-RFIvmuAMyp@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-258006-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-258006-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258006 Nuno Teixeira <eduardo@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eduardo@FreeBSD.org --- Comment #1 from Nuno Teixeira <eduardo@FreeBSD.org> --- Hello, 1. 'portclippy -C': --- FATAL: Makefile: DISTVERSIONPREFIX appears out-of-order. FATAL: Makefile: order must be PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTRE= VISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKG= NAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES(_\w+)?/DIST_SUBDIR= /EXTRACT_ONLY. --- it should be: --- PORTNAME=3D grafana DISTVERSIONPREFIX=3D v DISTVERSION=3D 8.1.2 --- 2. PORTREVISION must be set to zero since this port was updated (preference just remove "PORTREVISION=3D 1" 3. 'portclippy Makefile' sugests correction variables block: --- # PORTNAME block PORTNAME +DISTVERSIONPREFIX DISTVERSION -DISTVERSIONPREFIX PORTREVISION CATEGORIES MASTER_SITES PKGNAMESUFFIX DISTFILES # Maintainer block MAINTAINER COMMENT # License block LICENSE LICENSE_FILE # BROKEN/IGNORE/DEPRECATED messages ONLY_FOR_ARCHS # Dependencies RUN_DEPENDS # USES block USES USE_GITHUB USE_RC_SUBR -TAG # USES=3Dgo related variables GO_TARGET GO_BUILDFLAGS # Standard bsd.port.mk variables SUB_LIST -GRAFANA_USER -GRAFANA_GROUP # Users and groups block USERS GROUPS # Packaging list block PLIST_SUB # Unknown variables # WARNING: # Portclippy did not recognize the following variables. # They could be local variables only, misspellings of # framework variables, or Portclippy needs to be made aware # of them. Please double check them. # # Prefix them with an _ to tell Portclippy to ignore them. # This is also an important signal for other contributors # who are working on your port. It removes any doubt of # whether they are framework variables or not and whether # they are safe to remove/rename or not. GRAFANA_DATADIR +GRAFANA_GROUP GRAFANA_HOMEDIR GRAFANA_LOGDIR GRAFANA_PLUGINDIR GRAFANA_PROVISIONINGDIR +GRAFANA_USER +TAG --- 4. 'portfmt -D Makefile' sugests some alphabetical order too: --- --- Makefile +++ Makefile @@ -30,18 +30,17 @@ USE_RC_SUBR=3D grafana TAG=3D 103f8fa -GO_TARGET=3D ./pkg/cmd/grafana-server \ - ./pkg/cmd/grafana-cli +GO_TARGET=3D ./pkg/cmd/grafana-cli ./pkg/cmd/grafana-server GO_BUILDFLAGS=3D -ldflags=3D"-w -X main.version=3D${PORTVERSION} -X main.commit=3D${TAG}" -SUB_LIST=3D GRAFANA_USER=3D${GRAFANA_USER} \ - GRAFANA_GROUP=3D${GRAFANA_GROUP} \ +SUB_LIST=3D GRAFANA_BUILDHASH=3D8ea303538f79ee32b68a \ GRAFANA_DATADIR=3D${GRAFANA_DATADIR} \ + GRAFANA_GROUP=3D${GRAFANA_GROUP} \ GRAFANA_HOMEDIR=3D${GRAFANA_HOMEDIR} \ GRAFANA_LOGDIR=3D${GRAFANA_LOGDIR} \ GRAFANA_PLUGINDIR=3D${GRAFANA_PLUGINDIR} \ GRAFANA_PROVISIONINGDIR=3D${GRAFANA_PROVISIONINGDIR} \ - GRAFANA_BUILDHASH=3D8ea303538f79ee32b68a + GRAFANA_USER=3D${GRAFANA_USER} GRAFANA_USER?=3D grafana GRAFANA_GROUP?=3D grafana --- Could you take a look at portlint/portclippy/portfmt tools? what do you think? Thanks --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-258006-7788-RFIvmuAMyp>