From owner-freebsd-current  Wed Sep 10 13:42:08 1997
Return-Path: <owner-freebsd-current>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id NAA25824
          for current-outgoing; Wed, 10 Sep 1997 13:42:08 -0700 (PDT)
Received: from Octopussy.MI.Uni-Koeln.DE (Octopussy.MI.Uni-Koeln.DE [134.95.166.20])
          by hub.freebsd.org (8.8.7/8.8.7) with SMTP id NAA25817
          for <freebsd-current@freebsd.org>; Wed, 10 Sep 1997 13:42:05 -0700 (PDT)
Received: from x14.mi.uni-koeln.de ([134.95.219.124]) by Octopussy.MI.Uni-Koeln.DE with SMTP id AA20138
  (5.67b/IDA-1.5 for <freebsd-current@FreeBSD.ORG>); Wed, 10 Sep 1997 22:42:01 +0200
Received: (from se@localhost) by x14.mi.uni-koeln.de (8.8.7/8.6.9) id WAA01029; Wed, 10 Sep 1997 22:31:30 +0200 (CEST)
X-Face: "<d]#=8pzx);RzeqSKI86OVa7=!0/(uRa.+B.9Z9\eNUn@UG?!`y7yt2dFNn%k4'.}](uE%
 yCO)$e&Y1%3EO~ifu6Q-#YUM&JZ't,}JkPnAz,8Dj33u%@GBi%[Y#LHz$]h7a<p4)-jKI7~sKjlP-^
 EvA[G;]v&0]W!EL%shs,{7x0|oqN4YVIs5,NI#,V{9"WF):5&RkOhyj*#-IAG}Tnu;YCF,d
Message-Id: <19970910223130.58665@mi.uni-koeln.de>
Date: Wed, 10 Sep 1997 22:31:30 +0200
From: Stefan Esser <se@FreeBSD.ORG>
To: Simon Shapiro <Shimon@i-connect.net>
Cc: freebsd-current@FreeBSD.ORG
Subject: Re: Warning in pci_compat.c
References: <XFMail.970910112205.Shimon@i-Connect.Net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.74
In-Reply-To: <XFMail.970910112205.Shimon@i-Connect.Net>; from Simon Shapiro on Wed, Sep 10, 1997 at 11:22:05AM -0700
Sender: owner-freebsd-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Sep 10, Simon Shapiro <Shimon@i-connect.net> wrote:
> This is another one.  From a different area.  Again, do we have to suffer
> this indignation? :-)
> 
> cc -c -O -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit 
> -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes  -Wpointer-arith 
> -nostdinc -I- -I. -I../.. -I../../../include -DEXT2FS -DFAILSAFE -DSAFETY
> -DUMAPFS_DIAGNOSTIC -DKERNFS_DIAGNOSTIC -DNULLFS_DIAGNOSTIC -DDEVFS -DNFS
> -DFFS -DTCPDEBUG -DIPDIVERT -DINET -DCOMPAT_43 -DKERNEL -include
> opt_global.h  ../../pci/pci_compat.c
> .../../pci/pci_compat.c: In function `pci_map_int':
> .../../pci/pci_compat.c:172: warning: passing arg 3 of `intr_create' from
> incompatible pointer type

Yes, we have have to suffer ... :)

The interrupt handler had been defined differently
for different bus types. We should (IMHO) have:

void inthandler(void*);

But ISA handlers are called with a unit number, and
PCI handlers used to return an int ...

Regards, STefan