From owner-svn-src-all@FreeBSD.ORG Fri Jun 11 20:27:38 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A3F01065672; Fri, 11 Jun 2010 20:27:38 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 663458FC1C; Fri, 11 Jun 2010 20:27:37 +0000 (UTC) Received: by vws20 with SMTP id 20so576038vws.13 for ; Fri, 11 Jun 2010 13:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=Af0vrgdtglrWwpzoLh6tcgRbWaE1+uUHucMT6vzJYxw=; b=FEsCnpsmz2LTlJPNocPLq3xZThcj4hA8L4ZS3sgdmOU5cr+Fxhyk9+gPAL4XcGVk5l ddIbkfN8Fz3E5hwlX8oIzM1HqFTPb16mLYeh7gVrt8I1NOLp9QiR0OOk9dFJB6YzaHxu e1SFA3kMWHaREqhNCh9p0ALHy4D7DMgxVvj3g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=pyU3kfc8i4bUHFRwQUSxHTvolus5Tkv4DPeybQ5NPOmR5uJ++mMZ9Hj4ZWaHwhoGDQ vNAAVO5w9gxQWA08+XNtOZhyEtZmm0e+sRnZ+OWUpHndXoKLYAeE4rdHIVWmghZadbU5 zBq5C0/iCG2zhsPeExPhwHhMJXdseiDyzFQ1M= MIME-Version: 1.0 Received: by 10.224.64.156 with SMTP id e28mr916668qai.200.1276288056258; Fri, 11 Jun 2010 13:27:36 -0700 (PDT) Received: by 10.229.238.199 with HTTP; Fri, 11 Jun 2010 13:27:36 -0700 (PDT) In-Reply-To: <20100611202054.A26508@maildrop.int.zabbadoz.net> References: <201006111903.o5BJ3xp1062600@svn.freebsd.org> <20100611193903.W26508@maildrop.int.zabbadoz.net> <20100611200936.B26508@maildrop.int.zabbadoz.net> <20100611202054.A26508@maildrop.int.zabbadoz.net> Date: Fri, 11 Jun 2010 13:27:36 -0700 Message-ID: From: Jack Vogel To: "Bjoern A. Zeeb" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Jack F Vogel , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209060 - head/sys/dev/ixgbe X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2010 20:27:38 -0000 OK, that's kinda what I was guessing... Damn, guess I'll have to change it back. Thanks for letting me know. Jack On Fri, Jun 11, 2010 at 1:23 PM, Bjoern A. Zeeb wrote: > On Fri, 11 Jun 2010, Jack Vogel wrote: > > Odd though, because that code is in the driver on a system with 16 cores >> and >> I'm >> not hearing about any problem from my test engineer. >> > > So this makes it all go away: > > --- //depot/user/bz/vimage/src/sys/dev/ixgbe/ixgbe.c 2010-06-09 > 07:53:30.000000000 0000 > +++ /zoo/bz/p4/bz_vimage/src/sys/dev/ixgbe/ixgbe.c 2010-06-09 > 07:53:30.000000000 0000 > --- /tmp/tmp.96356.27 2010-06-11 16:19:14.000000000 -0400 > +++ /zoo/bz/p4/bz_vimage/src/sys/dev/ixgbe/ixgbe.c 2010-06-11 > 16:16:02.000000000 -0400 > @@ -3637,7 +3637,7 @@ ixgbe_setup_receive_ring(struct rx_ring > goto skip_head; > > /* First the header */ > - rxbuf->m_head = m_gethdr(M_WAITOK, MT_DATA); > + rxbuf->m_head = m_gethdr(M_DONTWAIT, MT_DATA); > if (rxbuf->m_head == NULL) { > error = ENOBUFS; > goto fail; > @@ -3659,7 +3659,7 @@ ixgbe_setup_receive_ring(struct rx_ring > > skip_head: > /* Now the payload cluster */ > - rxbuf->m_pack = m_getjcl(M_WAITOK, MT_DATA, > + rxbuf->m_pack = m_getjcl(M_DONTWAIT, MT_DATA, > M_PKTHDR, adapter->rx_mbuf_sz); > if (rxbuf->m_pack == NULL) { > error = ENOBUFS; > > > Are they running with WITNESS enabled to see the locking warnings? > > /bz >