From owner-svn-src-all@FreeBSD.ORG Sun Nov 21 12:24:37 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A175106564A; Sun, 21 Nov 2010 12:24:37 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 11BA28FC08; Sun, 21 Nov 2010 12:24:35 +0000 (UTC) Received: by bwz2 with SMTP id 2so5453528bwz.13 for ; Sun, 21 Nov 2010 04:24:34 -0800 (PST) Received: by 10.204.49.67 with SMTP id u3mr4103377bkf.167.1290342274691; Sun, 21 Nov 2010 04:24:34 -0800 (PST) Received: from julie.lab.techwires.net (dslb-088-067-198-124.pools.arcor-ip.net [88.67.198.124]) by mx.google.com with ESMTPS id t10sm1827579bkj.16.2010.11.21.04.24.32 (version=SSLv3 cipher=RC4-MD5); Sun, 21 Nov 2010 04:24:33 -0800 (PST) Sender: Bernhard Schmidt From: Bernhard Schmidt To: Kostik Belousov Date: Sun, 21 Nov 2010 13:24:11 +0100 User-Agent: KMail/1.13.5 (FreeBSD/8.1-RELEASE; KDE/4.5.3; amd64; ; ) References: <201011211058.oALAwIkp052526@svn.freebsd.org> <20101121112520.GM2392@deviant.kiev.zoral.com.ua> In-Reply-To: <20101121112520.GM2392@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201011211324.12283.bschmidt@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r215618 - stable/8/sys/net80211 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2010 12:24:37 -0000 On Sunday 21 November 2010 12:25:20 Kostik Belousov wrote: > On Sun, Nov 21, 2010 at 10:58:18AM +0000, Bernhard Schmidt wrote: > > Author: bschmidt > > Date: Sun Nov 21 10:58:18 2010 > > New Revision: 215618 > > URL: http://svn.freebsd.org/changeset/base/215618 > > > > Log: > > MFC r199076: > > The isr_intval in ieee80211req_scan_result structure should be 16 bit. > > This makes ifconfig list scan display the correct beacon interval > > (previously it would int overflow). As a side effect, this makes the > > ieee80211req_scan_result word aligned. > > > > Submitted by: Paul B Mahol > > Committed by: rpaulo > > > > Modified: > > stable/8/sys/net80211/ieee80211_ioctl.h > > > > Directory Properties: > > stable/8/sys/ (props changed) > > stable/8/sys/amd64/include/xen/ (props changed) > > stable/8/sys/cddl/contrib/opensolaris/ (props changed) > > stable/8/sys/contrib/dev/acpica/ (props changed) > > stable/8/sys/contrib/pf/ (props changed) > > stable/8/sys/dev/xen/xenpci/ (props changed) > > > > Modified: stable/8/sys/net80211/ieee80211_ioctl.h > > ========================================================================= > > ===== --- stable/8/sys/net80211/ieee80211_ioctl.h Sun Nov 21 10:56:04 > > 2010 (r215617) +++ stable/8/sys/net80211/ieee80211_ioctl.h Sun Nov 21 > > 10:58:18 2010 (r215618) @@ -790,7 +790,7 @@ struct > > ieee80211req_scan_result { > > > > uint16_t isr_flags; /* channel flags */ > > int8_t isr_noise; > > int8_t isr_rssi; > > > > - uint8_t isr_intval; /* beacon interval */ > > + uint16_t isr_intval; /* beacon interval */ > > > > uint8_t isr_capinfo; /* capabilities */ > > uint8_t isr_erp; /* ERP element */ > > uint8_t isr_bssid[IEEE80211_ADDR_LEN]; > > Doesn't this change ABI ? Yes, it does. While going over the changes I must have mixed that up with struct ieee80211_scan_entry which would have been save you change. Unfortunately that didn't break any of my test setups.. Anyways, I'll revert it. -- Bernhard