From owner-svn-src-head@freebsd.org Thu Jun 9 14:10:43 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CBF7B70D0C; Thu, 9 Jun 2016 14:10:43 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 8E0911EDA; Thu, 9 Jun 2016 14:10:43 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by freefall.freebsd.org (Postfix) with ESMTP id C09FB124D; Thu, 9 Jun 2016 14:10:42 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Thu, 9 Jun 2016 14:10:25 +0000 From: Glen Barber To: "Simon J. Gerraty" Cc: svn-src-head@FreeBSD.org, stevek@juniper.net, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r301713 - head/sys/dev/random Message-ID: <20160609141025.GQ2323@FreeBSD.org> References: <201606090150.u591ohZa019497@repo.freebsd.org> <20160609130108.GN2323@FreeBSD.org> <90183.1465478734@kaos.jnpr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SvyA5ywaG/v2A5dH" Content-Disposition: inline In-Reply-To: <90183.1465478734@kaos.jnpr.net> X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 14:10:43 -0000 --SvyA5ywaG/v2A5dH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 09, 2016 at 06:25:34AM -0700, Simon J. Gerraty wrote: > Glen Barber wrote: > > > =20 > > > -void read_rate_increment(u_int); > > > +void random_harvest_queue(const void *, u_int, u_int, > > > + enum random_entropy_source); > > > +void read_rate_increment(u_int); > > > =20 > > > #define RANDOM_HARVESTQ_BOOT_ENTROPY_FILE "/boot/entropy" > > > =20 > >=20 > > This breaks sparc64. >=20 > Looks like defined(DEV_RANDOM) is relevant. > Wrapping the prototype in random_harvestq.h in >=20 > #ifndef DEV_RANDOM >=20 > would avoid this issue. > But backing out until we check if that fixes the original issue steve > hit is probably best? >=20 IMHO, backing it out is the best solution for now, since a followup review will be required by so@ for a subsequent commit here. Glen --SvyA5ywaG/v2A5dH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXWXjRAAoJEAMUWKVHj+KTtQ4P/3wokoas8qRa8Lg922JAWVLY LM7o5/i0y9Yvx0pnYvxDiG5ksEiJ6gR8O7Mqasu1Ez8ajnXE1pn7IGNUTPKf9fcb w6FB78D6Bi1mxas0OeFe2HarL8JFNUQP4sCBxJNYWnqFARcsWr9qMlZpv3S0DKTW 2Oh+1jOZweJC7m/mO828mbs2guX6MGZ4pEDk1cDBvDPLNyK8d5AMM5E/RkEvzLx7 409Ko93mWsVK/RttolE2eV6QG0w9knSo4TST0a+rvvX80fxNf5SpqFc/OGrB0Xrr pDOW+f3G2Nnowgc0r1ZrABX+/qlnxhdFW/tNsuQpnSOjcBww5dJ15aj3PgyFr7Ew S5cL16idoF0BC0p4QsJACIX1FhveAXPJerPDn9+bS7Gp665ubsygL+dAHd+et23Q YOX5q8H1qMPq86A5gO/tPbsWoemiCqvqnig2qdjDx4ZdbvmpmecfhPjnEW3ziwh6 cXZfWQDvZPmcLEl6EoU2IewfvDiAaF0mO/oRhqLyFLWHdmwtZvbVKsXO1jKQB3OA SFX56R+jkw3OxcDjO+VGaHHr1pMWEThFnHZn9hPzHaTOtzzKzqdUGV0n05cu2lY4 yEo0+zRJ1/FsJBoVLkgTFzX6pZClZPN8SyyZrDWwMkbsc7YM9WiYRL0z+NGIDRR1 oRZ2mD77InMJXpG9uRTx =rBXV -----END PGP SIGNATURE----- --SvyA5ywaG/v2A5dH--