From owner-cvs-all@FreeBSD.ORG  Wed Mar 17 03:40:36 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7366616A4CE; Wed, 17 Mar 2004 03:40:36 -0800 (PST)
Received: from mtaw4.prodigy.net (mtaw4.prodigy.net [64.164.98.52])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 58B5443D46; Wed, 17 Mar 2004 03:40:36 -0800 (PST)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
	(db46d3484742175bc1d6ad538d149733@adsl-67-119-53-203.dsl.lsan03.pacbell.net
	[67.119.53.203])
	by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i2HBeWVM015299;
	Wed, 17 Mar 2004 03:40:34 -0800 (PST)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 2E48851932; Wed, 17 Mar 2004 03:40:29 -0800 (PST)
Date: Wed, 17 Mar 2004 03:40:29 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: "David O'Brien" <obrien@FreeBSD.org>
Message-ID: <20040317114028.GA62685@xor.obsecurity.org>
References: <200403170818.i2H8IFYU008824@repoman.freebsd.org>
	<Pine.BSF.4.58.0403171036060.94079@acrux.dbai.tuwien.ac.at>
	<Pine.BSF.4.58.0403171135480.94079@acrux.dbai.tuwien.ac.at>
	<20040317112344.GB86662@dragon.nuxi.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V"
Content-Disposition: inline
In-Reply-To: <20040317112344.GB86662@dragon.nuxi.com>
User-Agent: Mutt/1.4.2.1i
cc: cvs-ports@FreeBSD.org
cc: Gerald Pfeifer <gerald@pfeifer.com>
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/lang/gcc34 Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Mar 2004 11:40:36 -0000


--xHFwDpU9dbj6ez1V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 17, 2004 at 03:23:44AM -0800, David O'Brien wrote:
> On Wed, Mar 17, 2004 at 11:50:52AM +0100, Gerald Pfeifer wrote:
> > I'm afraid I know.  Your commit apparently broke the port an all platfo=
rms
> > but amd64. :-(
> >=20
> > Have you tested this following the instructions at
> >  http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/port=
ing-testing.html
> > ?  For invasive changes like this, I'd like to ask you to always test at
> > least i386 when committing changes to ports that I maintain.
>=20
> I *DID* test on i386 (5.2-CURRENT, full 'make world' just before testing
> the port).

Do you have additional bsd.port.mk patches in your tree?  The comment
in your commit log about bsd.port.mk now using a different default
value of CONFIGURE_TARGET seemed odd to me - there were patches
proposed to change this, but they were never committed because they
broke a lot of ports.

Kris

--xHFwDpU9dbj6ez1V
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAWDksWry0BWjoQKURAs8rAJ0WDdIrItvuRKK5OTABiAL9IubV1QCeI8HI
x6pDfK9EqdE+zQNwY+EJ47w=
=iqZj
-----END PGP SIGNATURE-----

--xHFwDpU9dbj6ez1V--