Date: Fri, 14 Apr 2017 05:38:33 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 210505] graphics/opencv: Update to 3.2 Message-ID: <bug-210505-13-BpjcjunIgm@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-210505-13@https.bugs.freebsd.org/bugzilla/> References: <bug-210505-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210505 --- Comment #55 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 181772 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D181772 add opencv3-core, update Can you rebase and make sure at least a few consumers build fine? Apologies= for the churn. > PKGNAMESUFFIX?=3D 3 [...] > PKGNAMESUFFIX=3D 3-${OCV_SLAVE} [...] > CONFLICTS_INSTALL=3D ${PKGBASE:S/${PORTNAME}3/${PORTNAME}/} According to comment 15 the latest version didn't need suffix, even less now (after comment 53). > MAINTAINER=3D jhale@FreeBSD.org Can you pick up ports r422467? Otherwise, approval is required if the new maintainer isn't the patch submitter. > GH_ACCOUNT=3D opencv GH_ACCOUNT=3D${PORTNAME} is already set by default. > PORTSCOUT=3D limit:^3\. Why? 4.0 hasn't been released yet, so we don't know how much work it'd be to update the port. > CXXFLAGS+=3D -std=3Dc++11 Convert to USE_CXXSTD=3Dc++11. > CXXFLAGS+=3D -stdlib=3Dlibc++ libc++ isn't supported on sparc64, mips* and DragonFly yet. > USES=3D ... compiler:c++11-lang ... Can you re-apply ports r423063 instead? It may break GCC platforms otherwis= e. https://lists.freebsd.org/pipermail/svn-src-all/2015-March/101722.html > OPTIONS_GROUP_SIMD=3D SSE SSE2 SSE3 SSSE3 SSE41 SSE42 \ > AVX AVX2 FMA3 POPCNT NEON VFPV3 Can you properly apply ports r423062? Users may not be aware NEON/VFPV3 are armv6-specific while the rest is x86-specific. > OPTIONS_EXCLUDE=3D DC1394 EXAMPLES EXTRA_MODULES ARAVIS FFMPEG \ Try to alphabetically sort options. > LIB_DEPENDS+=3D libtesseract.so:graphics/tesseract Why +=3D and not =3D? Mandatory deps are supposed to be at the top of Makef= ile. > .include <bsd.port.options.mk> > > .if ${PORT_OPTIONS:MEXTRA_MODULES} > GH_PROJECT=3D opencv_contrib:extra_mod \ > opencv_3rdparty:extra_mod_boostdesc \ > opencv_3rdparty:extra_mod_vgg > GH_TAGNAME=3D ${PORTVERSION}:extra_mod \ > 34e4206aef44d50e6bbcd0ab06354b52e7466d26:extra_mod_boostdesc \ > fccf7cd6a4b12079f73bbfb21745f9babcd4eb1d:extra_mod_vgg > LIB_DEPENDS+=3D libgflags.so:devel/gflags \ > libglog.so:devel/glog \ > libhdf5.so:science/hdf5 \ > libprotobuf.so:devel/protobuf > # libceres.so:math/ceres-solver > EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-modules_sfm_CMakeLists.txt > .endif Convert to option helpers and GH_TUPLE e.g., EXTRA_MODULES_GH_TUPLE=3D opencv:opencv_contrib:${GH_TAGNAME}:extra= _mod \ ... EXTRA_MODULES_LIB_DEPENDS=3D libgflags.so:devel/gflags \ ... EXTRA_MODULES_EXTRA_PATCHES=3D=20 ${PATCHDIR}/extra-patch-modules_sfm_CMakeLists.txt > .if ${PORT_OPTIONS:MGTK2} && ${PORT_OPTIONS:MOPENGL} > LIB_DEPENDS+=3D libgtkglext-x11-1.0.so:x11-toolkits/gtkglext > .endif > [...] > .if ${PORT_OPTIONS:MQT4} && ${PORT_OPTIONS:MOPENGL} > USE_QT4+=3D opengl > .endif Can you pick up ports r423061? It should help to drop bsd.port.options.mk l= ine. > post-patch: [...] > .if ${PORT_OPTIONS:MOPENGL} Convert to target option helpers, see /usr/ports/CHANGES from 20150701. > -GSTREAMER_USE=3D GSTREAMER1=3Dyes > +GSTREAMER_USE=3D gstreamer1=3Dyes Try to avoid such gratuitous changes. > -@comment include/opencv2/opencv.hpp > -@comment include/opencv2/opencv_modules.hpp Don't remove these to avoid "poudriere bulk -t" or "poudriere testport" complaining: =3D=3D=3D> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: include/opencv2/cvconfig.h Error: Orphaned: include/opencv2/opencv.hpp Error: Orphaned: include/opencv2/opencv_modules.hpp --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210505-13-BpjcjunIgm>