From nobody Mon Sep 22 15:44:18 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cVnTw580Mz683jD; Mon, 22 Sep 2025 15:44:20 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cVnTw4RLdz3bv7; Mon, 22 Sep 2025 15:44:20 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758555860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=J7ZUtISCuFqL/54Z6PkZsDgfIabTh1gavL3W8vMuTz0=; b=j4GeKRR4h/EplXUN0jrUlq5PHLTd3IWxMrhvFkJhHRz9WLVt4V6LT+JOgRDU5l+Cf9V/HG otawZAJPrv0sLR1FXkO1qBGAuTjcifxFTXQQ9dTrEPpCT4t1GFjKCVAk6zGx3kKizJlzXx gQi++inIHUTYjux2kTFz5rcDuz36hvK0dI8w072aDM/SMgRzPCx8Qq2uv+/qOy1t8SBvJh kn0hULV8rg/cK/DOh4ueSwgVjx10U6SpP/a6ToEJzIU//fFzf+eGCrZcBCcvVyrwbsV9q9 irdAkcQA7fDz5L94bO2WJVRY6aRtvKjB2UkcHO866pzy26NlCx4H2+mivyeS6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758555860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=J7ZUtISCuFqL/54Z6PkZsDgfIabTh1gavL3W8vMuTz0=; b=fgs8aiXNpcQEn91tuKdXiiH+fpIqSkFo40avp7tXAh5g4xZyPWOxTeKDXZrscJ06zH1sm9 Bp+D4pKuj2phHyaRVBnykGElzXHIadyVF5X0amIxXELlHgA3aan28Hk6vBB7a66GyK9M4V nzGsub5g4P85P7FUh7BSkbLw4E5jFiT5FHlxjLjohhof4u6SzJYsBlDrOgBwx76ksnv51v Fdz5tfUkMx8p95U2hFKJNcn4GJR7qWbvFSMMfH4CPVfjLArAtYEG0VAakhCSraLYVD9hfp lPpj0POuM6XVMp3ii6nLgvRYkwbqTFFpXVFWRwEirfK+TZTaWtpa5wA7H2LmEA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758555860; a=rsa-sha256; cv=none; b=AexacpkiAyD7fXICruIuQxwZG9Jxq6boNRnJXb/yMdu3vigo2YldLFbD7LU8Y6pzgF8orK 1sRiGdyWzYR6EfzTGGCq9VY1EKp3o3OiVlfEx5ElW8uXIZhrWz6WmpWcSPugmcY9K4zEAG Jsx/6I8F0P7HLKe8dmz9+cxJtbYBQJj4u+havmoXIkb/AjiNi/a9/RR+FkjCG1F3kL0cV+ w0ZfGV5B0uCEf58bLax2EDLNg0Bdf+xlAE3ZJMGiKgAZPKoq1JyAewcMhJiTJ6VjXEe356 L0vePuDeBNlIEIle7aZi3WpnD3XdES/r/HlNW205wlMxaL52buo+yN7acOFyNg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2a01:e11:2002:4280::13:1] (unknown [IPv6:2a01:e11:2002:4280::13:1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cVnTw06KXzvNx; Mon, 22 Sep 2025 15:44:19 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: Date: Mon, 22 Sep 2025 17:44:18 +0200 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Guido Falsi Subject: Re: git: 0ec13430c583 - main - sys/netinet6: Fix ABI breakage introduced with RFC 7217 support To: "Jonathan T. Looney" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202509220759.58M7xkrM031432@gitrepo.freebsd.org> Content-Language: en-US, it, en-GB Autocrypt: addr=madpilot@FreeBSD.org; keydata= xsBNBE+G+l0BCADi/WBQ0aRJfnE7LBPsM0G3m/m3Yx7OPu4iYFvS84xawmRHtCNjWIntsxuX fptkmEo3Rsw816WUrek8dxoUAYdHd+EcpBcnnDzfDH5LW/TZ4gbrFezrHPdRp7wdxi23GN80 qPwHEwXuF0X4Wy5V0OO8B6VT/nA0ADYnBDhXS52HGIJ/GCUjgqJn+phDTdCFLvrSFdmgx4Wl c0W5Z1p5cmDF9l8L/hc959AeyNf7I9dXnjekGM9gVv7UDUYzCifR3U8T0fnfdMmS8NeI9NC+ wuREpRO4lKOkTnj9TtQJRiptlhcHQiAlG1cFqs7EQo57Tqq6cxD1FycZJLuC32bGbgalABEB AAHNIkd1aWRvIEZhbHNpIDxtYWRwaWxvdEBGcmVlQlNELm9yZz7CwHgEEwECACIFAk+G+3MC GwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEBrmhg5Wy9KT2uIIAIrawQ89TnqEhi2C OEQAhx3uqWZuNoS6NyiSgsRCmtSnT2GOgH4Ucbr/I37SkV1B3K6HkoL6lwN8Gjf5KOgLqmTi E1W3RTwS7l8PSvdnjM9i7g351R4mTijtxawB/JcQf/Kge3Yqr1V4g6H+wQXHUStmHThbupuN trzRphvR/e5ekT0FTyVfPmpcbm68i2bwZnKUex/TNIECBykYh8b+SYMLhENf2ayRjCIWS2Ad 7tnTKhMtnS5jtW6qjBy4RoTpQD6oR1xIgkTRlQ49roVCUfdHb+Y/kh+U9G1IcoNy4vkg9IfP dwpSfnP+a8j0AZ1hMnOLZ1fYoQrs+4gVLy8Fs7TOwU0EUxB7QQEQAKFhrDceoPdK/IHDSmoj 6SQYisvM7VdhcleS7E9DoEAVt7yMbf6HbbMVTTY6ckvwTWQssywLBXNVqxgc4WLJjzfUhgef +WE75M3+WFYlOVQLGZY/zEVgma1raYnOHNAOzeHLDmEXjbZP6vGAeDyBbGfQPpE7qGYZ7ube T3XwQO+PklcCrvOPj2ZPcAxGNS2xVU/LzONqCrJqLMJSIcCdsbiSP4G5PnDFHtMokaTY6OEr 8OEQfOAerhcHUa/z7Uu8YtmaqKH+QGkE/WEgaRqSiTnv0JOTD+DxehaqvoKPPZ++2NpCZMHB 2i6A/xifmQwEiIjEXtcueBRzkNUQkxhqZyS13SrhocL9ydtaVPBzZatAEjUDDEJmAMLVFs45 qfyhMiNapHJo2n3MW/E5omqCvEkDdWX/en3P7CK2TemeaDghMsgkNKax/z0wNo5UZCkOPOz0 xpNiUilOVbkuezZZNg65741qee2lfXhQIaZ66yT7hphc/N/z3PIAtLeze4u1VR2EXAuZ2sWA dlKCNTlJMsaU/x70BV11Wd/ypnVzM68dfdQIIAj1iMFAD/lXGlEUmKXg5Ov2VQDlTntQoanC YrAg+8CttPzjrydgLZFq3hrtQmfc0se5yv1WHS69+BsUOG09RvvawUDZxUjW19kyeN9THaNR gow3kSuArUp6zSmJABEBAAHCwF8EGAEIAAkFAlMQe0ECGwwACgkQGuaGDlbL0pMN5wgA4bCk X/qwEVC06ToeR6C2putmSWQMgpDaqrv65Hubo+QGmg2P4ewTYQQ4g6oYWS03qHxqVVWhKz7F jfrV+dH8qbCLfSgIcvdBha7ayGZVrsiuMLKGbw36fcmkZPpSDOfHcP0XH8Z+u9CWj0xUkTxA lZ/7i6gYSUpG2JWNtdmE/X8VVEyXusCLwy0K0BI60A/4dRTIX3C4QKrJ3ZbUXegz70ynjHf+ lQMZ9IZKASoRMuS5FozPQh6abvmwZEPdf5I9riUElzvHrqJ8Bx0t3Pujdoth+yNHpnBxrtO8 LkQdrQ58P0SwcaIX33T2U9pG8bhu5YVR88FQ8OQ0cEsPBpDncg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/22/25 17:37, Jonathan T. Looney wrote: > On Mon, Sep 22, 2025 at 3:59 AM Guido Falsi > wrote: > > diff --git a/sys/netinet6/in6.c b/sys/netinet6/in6.c > index 4f756a75fac7..8ef755e2dc0a 100644 > --- a/sys/netinet6/in6.c > +++ b/sys/netinet6/in6.c > @@ -2604,6 +2604,8 @@ in6_domifattach(struct ifnet *ifp) >         COUNTER_ARRAY_ALLOC(ext->icmp6_ifstat, >             sizeof(struct icmp6_ifstat) / sizeof(uint64_t), M_WAITOK); > > +       ext->dad_failures = counter_u64_alloc(M_WAITOK); > + >         ext->nd_ifinfo = nd6_ifattach(ifp); >         ext->scope6_id = scope6_ifattach(ifp); >         ext->lltable = in6_lltattach(ifp); > @@ -2639,6 +2641,7 @@ in6_domifdetach(struct ifnet *ifp, void *aux) >         COUNTER_ARRAY_FREE(ext->icmp6_ifstat, >             sizeof(struct icmp6_ifstat) / sizeof(uint64_t)); >         free(ext->icmp6_ifstat, M_IFADDR); > +       counter_u64_free(ext->dad_failures); >         free(ext, M_IFADDR); >  } > > > This seems like it is probably a low-frequency event. If so, why is a > counter a better choice for this than an atomic? > I used counters because they were already being used in the netinet6 code, and are a good match for the use. -- Guido Falsi