From owner-cvs-all Wed Jul 10 17:30:46 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6192637B400; Wed, 10 Jul 2002 17:30:40 -0700 (PDT) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1700D43E3B; Wed, 10 Jul 2002 17:30:40 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.5/8.12.4) with ESMTP id g6B0UdLA076673; Wed, 10 Jul 2002 17:30:39 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.5/8.12.4/Submit) id g6B0UdAm076672; Wed, 10 Jul 2002 17:30:39 -0700 (PDT) (envelope-from dillon) Date: Wed, 10 Jul 2002 17:30:39 -0700 (PDT) From: Matthew Dillon Message-Id: <200207110030.g6B0UdAm076672@apollo.backplane.com> To: Peter Wemm Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/chmod chmod.c References: <20020710234615.61E5E3808@overcee.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG : :Matthew Dillon wrote: : :> I suppose the minimal fix is to remove __printf0like from err(), :> errx(), and warn() in /usr/src/include/err.h. So that is what I will :> do if this problem isn't fixed in the tree by 9:00 p.m. PDT tonight. : :No, the correct minimal fix is to stub out the attributes, that's why :we have fine granularity on them! eg: You want to disable the attribute globally? The only problem with it is with three functions that pass NULL. -Matt Matthew Dillon : /* Compiler-dependent macros that rely on FreeBSD-specific extensions. */ :-#if __FreeBSD_cc_version >= 300001 :+#if __FreeBSD_cc_version >= 300001 && !defined(__sparc64__) : #define __printf0like(fmtarg, firstvararg) \ : __attribute__((__format__ (__printf0__, fmtarg, firstvararg))) : #else : #define __printf0like(fmtarg, firstvararg) : :The sparc64 thing just was an example. It may need this instead: :#if __FreeBSD_cc_version >= 300001 && __FreeBSD_cc_version < 500003 : :There, problem solved. : :Cheers, :-Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message