From owner-cvs-ports@FreeBSD.ORG  Sat Feb 11 23:08:26 2012
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id ADC82106566B;
	Sat, 11 Feb 2012 23:08:26 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 172-17-150-251.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 5EA7F1501BA;
	Sat, 11 Feb 2012 23:08:25 +0000 (UTC)
Message-ID: <4F36F4E8.8040008@FreeBSD.org>
Date: Sat, 11 Feb 2012 15:08:24 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:10.0) Gecko/20120201 Thunderbird/10.0
MIME-Version: 1.0
To: "Philip M. Gollucci" <pgollucci@FreeBSD.org>
References: <201202112237.q1BMbOHK097436@repoman.freebsd.org>
In-Reply-To: <201202112237.q1BMbOHK097436@repoman.freebsd.org>
X-Enigmail-Version: 1.3.5
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, Gea-Suan Lin <gslin@gslin.org>, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/sysutils/p5-MogileFS-Server Makefile
 ports/sysutils/p5-MogileFS-Server/files mogilefsd.in mogstored.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Feb 2012 23:08:26 -0000

These rc.d files are not even complete, never mind meeting the
requirements listed in
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html

Additionally, in both of them _flags is used for -d and --config where
those things should be in command_args instead. In mogstored.in there's
also a literal /usr/local.

I'll leave it as an exercise for the reader to determine what (rather
important) line is missing altogether.


Doug


On 02/11/2012 14:37, Philip M. Gollucci wrote:
> pgollucci    2012-02-11 22:37:24 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     sysutils/p5-MogileFS-Server Makefile 
>   Added files:
>     sysutils/p5-MogileFS-Server/files mogilefsd.in mogstored.in 
>   Log:
>   - Add rc.d files
>   - Bump PORTREVISION
>   
>   PR:             ports/164876  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=164876
>   Submitted by:   Gea-Suan Lin <gslin@gslin.org>
>   With Hat:       perl@
>   
>   Revision  Changes    Path
>   1.23      +2 -0      ports/sysutils/p5-MogileFS-Server/Makefile
>   1.1       +19 -0     ports/sysutils/p5-MogileFS-Server/files/mogilefsd.in (new)
>   1.1       +19 -0     ports/sysutils/p5-MogileFS-Server/files/mogstored.in (new)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/p5-MogileFS-Server/Makefile.diff?&r1=1.22&r2=1.23&f=u
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/p5-MogileFS-Server/files/mogilefsd.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/p5-MogileFS-Server/files/mogstored.in
> 



-- 

	It's always a long day; 86400 doesn't fit into a short.

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/