From owner-freebsd-audit  Wed May  9 14:27:18 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP id 5C3EE37B422
	for <audit@FreeBSD.ORG>; Wed,  9 May 2001 14:27:15 -0700 (PDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.11.3/8.11.1) with ESMTP id f49LR7b40095;
	Wed, 9 May 2001 15:27:12 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Message-Id: <200105092127.f49LR7b40095@harmony.village.org>
To: Dima Dorfman <dima@unixfreak.org>
Subject: Re: jot(1) patch 
Cc: audit@FreeBSD.ORG
In-reply-to: Your message of "Wed, 09 May 2001 14:04:32 PDT."
		<20010509210433.1BDA13E28@bazooka.unixfreak.org> 
References: <20010509210433.1BDA13E28@bazooka.unixfreak.org>  
Date: Wed, 09 May 2001 15:27:07 -0600
From: Warner Losh <imp@harmony.village.org>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <20010509210433.1BDA13E28@bazooka.unixfreak.org> Dima Dorfman writes:
: 	- use getopt
: 	- de-register

You should de __P() as well.  The changes add a prototype

: -usage()
: +usage(void)

which breaks K&R compatibility.  So do one or the other.  The one
thing worse than old K&R code in the tree is broken K&R code in the
tree.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message