From owner-freebsd-current@FreeBSD.ORG Tue Nov 16 17:52:58 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C734106564A; Tue, 16 Nov 2010 17:52:58 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 874788FC18; Tue, 16 Nov 2010 17:52:57 +0000 (UTC) Received: by gwj20 with SMTP id 20so536408gwj.13 for ; Tue, 16 Nov 2010 09:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=gGzOmkDQAnN2sQIWAGWjI7Pee+mUT8fPdzenvyQLD4U=; b=P+25Ke1qyZKpQ5zPbQySLXSk88WG7fDa23eXA9Lav8txCd8wg52dV2yNTutG3vGr40 FDaQguS/KdPpNfqAJhB0Sug/CXhwphJljz0L57ZrBlxaGyeGfCL/skc2nuMFPjMhxRJE jtP5+JYRM1zFaFR0D6/7hEhC9CRHiYAz9DOf8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=phjCIAccAAFcJ8dw4tATy8QeA2vg3D6aSLSI9HLmmAxC2FjHkHFFYCpuQgzsjFJZXb qANuCIVipE58GdRtfyxmdeulBIAoy5GNN8b/SW5hQunVybudPMDe50RAB41h+WHrdp3A YE1EM1mZHmzHI5ni14LU/BwQff214IfvA2Tds= MIME-Version: 1.0 Received: by 10.216.82.197 with SMTP id o47mr7512660wee.45.1289929976116; Tue, 16 Nov 2010 09:52:56 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.198.27 with HTTP; Tue, 16 Nov 2010 09:52:56 -0800 (PST) In-Reply-To: <201011160912.27693.jhb@freebsd.org> References: <201011160829.13511.jhb@freebsd.org> <4CE28AE4.70101@yandex.ru> <201011160912.27693.jhb@freebsd.org> Date: Tue, 16 Nov 2010 09:52:56 -0800 X-Google-Sender-Auth: NRgn383jEBK6pv3JGpWOucqoQ_Q Message-ID: From: Garrett Cooper To: John Baldwin Content-Type: multipart/mixed; boundary=001636eefd2a02f74904952f3a30 Cc: Bruce Cran , freebsd-hackers@freebsd.org, Adrian Chadd , "Andrey V. Elsukov" , freebsd-current@freebsd.org Subject: Re: breaking the crunchgen logic into a share/mk file X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2010 17:52:58 -0000 --001636eefd2a02f74904952f3a30 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Tue, Nov 16, 2010 at 6:12 AM, John Baldwin wrote: > On Tuesday, November 16, 2010 8:45:08 am Andrey V. Elsukov wrote: >> On 16.11.2010 16:29, John Baldwin wrote: >> > Err, are there no longer hard links to all of the frontends for a give= n >> > crunch? =A0If so, that is a problem as it will make rescue much harder= to use. >> >> Yes, probably this patch is not needed and it should be fixed somewhere = in >> makefiles. But currently rescue does not have any hardlinks: >> http://pub.allbsd.org/FreeBSD-snapshots/i386-i386/9.0-HEAD-20101116-JPSN= AP/cdrom/livefs/rescue/ >> >> And what is was before: >> http://pub.allbsd.org/FreeBSD-snapshots/i386-i386/9.0-HEAD-20101112-JPSN= AP/cdrom/livefs/rescue/ > > That definitely needs to be fixed. The .mk file wasn't being installed. Could someone please test this patch for validity and commit it? More importantly, why didn't the above build process, or tinderbox fail properly with this change? Thanks, -Garrett --001636eefd2a02f74904952f3a30 Content-Type: text/x-patch; charset=US-ASCII; name="fix-crunchgen.patch" Content-Disposition: attachment; filename="fix-crunchgen.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ggl2yoqx0 SW5kZXg6IHNoYXJlL21rL01ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNoYXJlL21rL01ha2VmaWxl CShyZXZpc2lvbiAyMTUzMzMpCisrKyBzaGFyZS9tay9NYWtlZmlsZQkod29ya2luZyBjb3B5KQpA QCAtMyw3ICszLDggQEAKIAogRklMRVM9CWJzZC5SRUFETUUKIEZJTEVTKz0JYnNkLmFyY2guaW5j Lm1rCi1GSUxFUys9CWJzZC5jb21wYXQubWsgYnNkLmNwdS5tayBic2QuZGVwLm1rIGJzZC5kb2Mu bWsgYnNkLmR0cmFjZS5taworRklMRVMrPQlic2QuY29tcGF0Lm1rIGJzZC5jcnVuY2hnZW4ubWsg YnNkLmNwdS5taworRklMRVMrPQlic2QuZGVwLm1rIGJzZC5kb2MubWsgYnNkLmR0cmFjZS5tawog RklMRVMrPQlic2QuZW5kaWFuLm1rCiBGSUxFUys9CWJzZC5maWxlcy5tayBic2QuaW5jcy5tayBi c2QuaW5mby5tayBic2QuaW5pdC5tawogRklMRVMrPQlic2Qua21vZC5tawo= --001636eefd2a02f74904952f3a30--