From owner-svn-src-all@freebsd.org Tue Feb 21 15:05:10 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5845CE8EC6 for ; Tue, 21 Feb 2017 15:05:10 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm5-vm4.bullet.mail.ne1.yahoo.com (nm5-vm4.bullet.mail.ne1.yahoo.com [98.138.91.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6AF57CB8 for ; Tue, 21 Feb 2017 15:05:10 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1487689508; bh=WD+1NlH/QHRp2pgeTfZJ0m1kQ2JFRIbuJVdNotFOSpU=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=LMM78BpcQdLzCjLh77379a/SOAVVshW2jBL0xB8zEFmO/PeLcWssVM5u2UwGyH8obuTHv+k5F8Ps8/RmqQcBFX8qIb6mQe9EoEHclvgpflwCPZA7QzFyeGo/9bZb+u/1y0zwZ35kzKQsn7n7j354pOQZSs5IVQ7Tlnn72C2p4BpxTJc7EiknNrgdkQF6Rur8AL0YLrX78vifwHxL3Xi4Ch81V9zKGOiDjZv8W9J6ynGJujeLlb55XKXRRUncO2FlvDgtztgF8ly0KKsWHwcD8vgV1ahSYQlFfw4fK2EICd4oAeOBcBsoyl7CHXw0xgpDO0n2cl/M9soUgsL9Nf2C3A== Received: from [98.138.100.117] by nm5.bullet.mail.ne1.yahoo.com with NNFMP; 21 Feb 2017 15:05:08 -0000 Received: from [98.138.104.116] by tm108.bullet.mail.ne1.yahoo.com with NNFMP; 21 Feb 2017 15:05:08 -0000 Received: from [127.0.0.1] by smtp225.mail.ne1.yahoo.com with NNFMP; 21 Feb 2017 15:05:08 -0000 X-Yahoo-Newman-Id: 744113.46007.bm@smtp225.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: tWJ46TIVM1mMzotLfi8S1V7MdS0HkMzmSggCQTSmAPJyMbU GbFyu_Jt2d10DxVqznTvl5xYzQKJ05oT_jD_D4JhRz7srhSQA2BjWIeSOoLM ESTlbcOTvpMlzGEAsxxYl7Qv9vX5DN404ShIZCIpXnG5jS_YTxDWr3OAurFi aGBc0F8TuEYCmaNbohCpZN2xwqkmMhEjxhUHsYkxmD8usvZSxBNxZmITZ_pY MU7ZnIVnzltyAeUSGvFAqvEQ.B9xOwMV1E98F0.xYuNOcVi1.PCZQLlU0zt3 Vf_EYwjqgvfp23Lyj6iu3_bBdJ5rqFNZLnZCqWQZdo3dTUGzHeoDtIZ7ixEo Z5xr5XCaaFoWr9CHpcEZqrYQCvAtfpN483gGaBdL3kX0Jeab6EpEShrzJGq9 Ksov8fSDmfoj96qlbjTFZ29C_okSbpez7EfTK9vsCSDZd3hKH.G4mF5tsoNW yhfp2uJPWgPwoIibUtBM6flSngCAmvSlKG.c95gyMV_n.KDt1vF2.byiL5Wz tT86rExE_1r9BLNcv5NaQ9FPOEb3vP.0gPVqqE9LFC_u5 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r313878 - head/sys/kern To: Andriy Gapon , Bryan Drewery , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201702171540.v1HFeOAs074991@repo.freebsd.org> <7da9caa5-d938-d2d0-1228-0e8897dc5632@FreeBSD.org> <56ca9623-dc6f-41fc-ba81-e7486a4ba8e3@FreeBSD.org> From: Pedro Giffuni Message-ID: <7cd90b98-8749-a775-b5f2-3961e59bf5ed@FreeBSD.org> Date: Tue, 21 Feb 2017 10:07:49 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <56ca9623-dc6f-41fc-ba81-e7486a4ba8e3@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2017 15:05:10 -0000 On 2/21/2017 2:11 AM, Andriy Gapon wrote: > On 21/02/2017 02:42, Pedro Giffuni wrote: >> FWIW, >> >> >> On 2/20/2017 7:24 PM, Bryan Drewery wrote: >>> On 2/17/2017 7:40 AM, Mateusz Guzik wrote: >>>> Author: mjg >>>> Date: Fri Feb 17 15:40:24 2017 >>>> New Revision: 313878 >>>> URL: https://svnweb.freebsd.org/changeset/base/313878 >>>> >>>> Log: >>>> mtx: get rid of file/line args from slow paths if they are unused >>>> This denotes changes which went in by accident in r313877. >>> I really wish people would just revert their changes and recommit them >>> properly. The 'svn blame' on the code in r313877 will never show the >>> commit message here (r313878). So a person would only find this >>> explanation if they read 'svn log' on the file, which in the case of >>> sys/kern/kern_mutex.c there are 273 commits for. Are we expected to >>> read 'svn log' (in the future) for all changes in the hopes that a later >>> commit happens to mention it? >>> >>> As someone who so often is 'svn blame'ing code to understand it better >>> and to track regressions, commits like this that explain other commits >>> might as well have never been done. >> As I mentioned in another thread, other svn configurations (ASF, for example) >> permit editing the log message: >> >> http://help.collab.net/index.jsp?topic=/faq/changelog.html > How well do various svn exporters handle that? > Specifically, svn-> git ? > Good point: it doesn't. The change gets ignored but it doesn't break the converter. At least not immediately, the github converter in AOO breaks frequently but it is probably unrelated. Pedro.