From owner-freebsd-emulation@FreeBSD.ORG  Thu Nov 15 20:21:53 2007
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3F93216A418;
	Thu, 15 Nov 2007 20:21:53 +0000 (UTC)
	(envelope-from nox@saturn.kn-bremen.de)
Received: from gwyn.kn-bremen.de (gwyn.kn-bremen.de [212.63.36.242])
	by mx1.freebsd.org (Postfix) with ESMTP id E726213C46A;
	Thu, 15 Nov 2007 20:21:52 +0000 (UTC)
	(envelope-from nox@saturn.kn-bremen.de)
Received: by gwyn.kn-bremen.de (Postfix, from userid 10)
	id 2474D246DE1; Thu, 15 Nov 2007 20:58:58 +0100 (CET)
Received: from saturn.kn-bremen.de (nox@localhost [127.0.0.1])
	by saturn.kn-bremen.de (8.13.8/8.13.6) with ESMTP id lAFJv9mJ042887;
	Thu, 15 Nov 2007 20:57:09 +0100 (CET)
	(envelope-from nox@saturn.kn-bremen.de)
Received: (from nox@localhost)
	by saturn.kn-bremen.de (8.13.8/8.13.6/Submit) id lAFJv94S042886;
	Thu, 15 Nov 2007 20:57:09 +0100 (CET) (envelope-from nox)
From: Juergen Lock <nox@jelal.kn-bremen.de>
Date: Thu, 15 Nov 2007 20:57:08 +0100
To: freebsd-emulation@FreeBSD.org, freebsd-ports@FreeBSD.org
Message-ID: <20071115195708.GA42556@saturn.kn-bremen.de>
Mail-Followup-To: freebsd-emulation@FreeBSD.org,
	freebsd-ports@FreeBSD.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: 
Subject: qemu-devel port: please test -cdrom patch with non-FreeBSD guests
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Nov 2007 20:21:53 -0000

Hi!

 I would like to commit the patch below to the qemu-devel port that
chases recent FreeBSD atapi-cd.c commits (it fixes recent FreeBSD
guests no longer seeing a disc in the emulated cd drive) and I want to
make sure it doesn't introduce regressions, so I'd be grateful if you all
could test it with as many (especially non-FreeBSD) guests as possible,
using the emulated cd/dvd drive. (like, pass an iso as -cdrom and
try to access it from the guest, play with `eject cdrom' and
`change cdrom another.iso' monitor commands, etc.  Btw, at least Windows
guests also needed an expicit click on `eject' in the guest in order to
notice disc changes, so if thats still the case its at least not new.)

 Thanx,
	Juergen

Index: files/patch-hw-ide.c
@@ -0,0 +1,19 @@
+Index: qemu/hw/ide.c
+@@ -1339,6 +1341,8 @@
+                 case 0x2a:
+                     cpu_to_ube16(&buf[0], 28 + 6);
+                     buf[2] = 0x70;
++                    if (bdrv_is_inserted(s->bs))
++                        buf[2] = 0x40;
+                     buf[3] = 0;
+                     buf[4] = 0;
+                     buf[5] = 0;
+@@ -1347,7 +1351,7 @@
+ 
+                     buf[8] = 0x2a;
+                     buf[9] = 0x12;
+-                    buf[10] = 0x00;
++                    buf[10] = 0x08;
+                     buf[11] = 0x00;
+                     
+                     buf[12] = 0x70;