From owner-cvs-all Fri Jul 26 9:43:21 2002 Delivered-To: cvs-all@freebsd.org Received: from green.bikeshed.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 8075737B400; Fri, 26 Jul 2002 09:43:16 -0700 (PDT) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.6/8.11.6) with ESMTP id g6QGhGJ66380; Fri, 26 Jul 2002 12:43:16 -0400 (EDT) (envelope-from green@green.bikeshed.org) Message-Id: <200207261643.g6QGhGJ66380@green.bikeshed.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Josef Karthauser Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pcm mixer.c sndstat.c sound.c In-Reply-To: Your message of "Fri, 26 Jul 2002 17:15:14 BST." <20020726161514.GC40513@genius.tao.org.uk> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 26 Jul 2002 12:43:16 -0400 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Josef Karthauser wrote: > On Wed, Jul 24, 2002 at 09:49:46PM -0700, Brian Feldman wrote: > > green 2002/07/24 21:49:45 PDT > > > > Modified files: > > sys/dev/sound/pcm mixer.c sndstat.c sound.c > > Log: > > Fix some of the places where sound(4) can sleep with a lock held. (Help > > courtesy of fenner). > > > > And the crowd goes wild - or at least can boot unattended again :). You know,I don't think this code in general really WANTS to use mutexes! The locks it's using are over entire huge code segments, and it would be quite a bit of work to converting it to only locking structures. I don't know that using sx locks alone would solve the possibility of deadlock that exists now in the initialization routine paths... -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message