From owner-svn-src-all@freebsd.org Wed Oct 12 02:32:25 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2828C0DB1D; Wed, 12 Oct 2016 02:32:25 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: from mail-qk0-x22a.google.com (mail-qk0-x22a.google.com [IPv6:2607:f8b0:400d:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A1A0535A; Wed, 12 Oct 2016 02:32:25 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: by mail-qk0-x22a.google.com with SMTP id f128so13548514qkb.1; Tue, 11 Oct 2016 19:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=wLoVJiAgIyXW+alBLBhB/jYl69f2IENiyY2YSbNIf/g=; b=uuas3bbN2g3DKdRLyusP4L9PG5X7WNX9KZeU0p4CxxXIlWgMNsDGFMUUddGo2vJ6oG 2Mjc1A6/PDljCsKU+Z4876YiplXz1GahUMiGqQ3pVt8BdTJfD+1WiQcu6nkD10sePQpU f3o01fNDd3eN6US9UiyMqTOEvddoSlxHxtN1IhC52ByG+DBBJscIQX/0Kw334DYcEgw/ P0VbKa3WTHtyZysXmfiF76v6TIyD1fi9+971CJD/Akwda01fLPERsodjAEnseFkAvVu3 KBTtVOtTkLiKBPJToMtuOs5JJS/T+Z4W2h4l+LrZtmPt354LDeybI/36oA911UKk8+ph 9WxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=wLoVJiAgIyXW+alBLBhB/jYl69f2IENiyY2YSbNIf/g=; b=MeMbibH4+7nQpSu9F6aQgnL1SvKGDmnkjSMTX9sByFTED1JIYodbtGg0jOeupgAoxY 3Rh69h1nZsZsDUM7u6x8JQ6O2ch2Po4DK4Hct7Svmf8+g3e9WfUXPWjmgn4RbunVYaIs x+9svf80gbnHYXzWMQ5QlawLO0uYaV9ykCyxZaQtCxzviqSoJQFSDATYrefGIZHYsu3d qfRJNROS/IIOFRkk5RyQD49a12scH37hAOQ3BDbLkgCGr7YxfopccTRE+MFg9eUmacAa jC8V6Pfvpdbd9tbu0Dodx1DaxbM0Zky9MlVPKB8R0bLI5UExhre9y34sRkZgj5Sq8DQg 9Mlw== X-Gm-Message-State: AA6/9Rn7h6emRmiAtY72zJDtYsctVUxymLrD9HtVtVQCxelzGquyjcLv9ROJ+DM7a+XJqz7G+EIJGL0f6ymPSQ== X-Received: by 10.55.149.67 with SMTP id x64mr7136784qkd.135.1476239544652; Tue, 11 Oct 2016 19:32:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.53.208 with HTTP; Tue, 11 Oct 2016 19:32:24 -0700 (PDT) In-Reply-To: <201610120230.u9C2UYHf046690@repo.freebsd.org> References: <201610120230.u9C2UYHf046690@repo.freebsd.org> From: Jonathan Looney Date: Tue, 11 Oct 2016 22:32:24 -0400 Message-ID: Subject: Re: svn commit: r307083 - head/sys/netinet To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 02:32:26 -0000 On Tue, Oct 11, 2016 at 10:30 PM, Jonathan T. Looney wrote: > Author: jtl > Date: Wed Oct 12 02:30:33 2016 > New Revision: 307083 > URL: https://svnweb.freebsd.org/changeset/base/307083 > > Log: > Currently, when tcp_input() receives a packet on a session that matches a > TCPCB, it checks (so->so_options & SO_ACCEPTCONN) to determine whether or > not the socket is a listening socket. However, this causes the code to > access a different cacheline. If we first check if the socket is in the > LISTEN state, we can avoid accessing so->so_options when processing > packets > received for ESTABLISHED sessions. > > If INVARIANTS is defined, the code still needs to access both variables > to > check that so->so_options is consistent with the state. > > Reviewed by: gallatin > MFC after: 1 week > Sponsored by: Netflix > This should have also noted: Differential Revision: https://reviews.freebsd.org/D8221 Sorry for the omission! Jonathan