From owner-svn-src-all@FreeBSD.ORG Wed Feb 23 13:12:33 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4C6F106566B; Wed, 23 Feb 2011 13:12:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 3EC218FC12; Wed, 23 Feb 2011 13:12:32 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p1NDCSZp017313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Feb 2011 15:12:28 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p1NDCS6X068473; Wed, 23 Feb 2011 15:12:28 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p1NDCSGb068472; Wed, 23 Feb 2011 15:12:28 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 23 Feb 2011 15:12:28 +0200 From: Kostik Belousov To: John Baldwin Message-ID: <20110223131228.GN78089@deviant.kiev.zoral.com.ua> References: <201102231256.p1NCuPHN056220@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pQC2pbIvkpPv3Ssp" Content-Disposition: inline In-Reply-To: <201102231256.p1NCuPHN056220@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r218967 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Feb 2011 13:12:33 -0000 --pQC2pbIvkpPv3Ssp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 23, 2011 at 12:56:25PM +0000, John Baldwin wrote: > Author: jhb > Date: Wed Feb 23 12:56:25 2011 > New Revision: 218967 > URL: http://svn.freebsd.org/changeset/base/218967 >=20 > Log: > Fix off-by-one error in check against max_threads_per_proc. > =20 > Submitted by: arundel > MFC after: 1 week >=20 > Modified: > head/sys/kern/kern_thr.c >=20 > Modified: head/sys/kern/kern_thr.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/kern_thr.c Wed Feb 23 10:28:37 2011 (r218966) > +++ head/sys/kern/kern_thr.c Wed Feb 23 12:56:25 2011 (r218967) > @@ -153,7 +153,7 @@ create_thread(struct thread *td, mcontex > p =3D td->td_proc; > =20 > /* Have race condition but it is cheap. */ > - if (p->p_numthreads >=3D max_threads_per_proc) { > + if (p->p_numthreads > max_threads_per_proc) { > ++max_threads_hits; > return (EPROCLIM); > } I do not think there was off by one error. The create_thread() function is called to create new thread, and before the process thread counter is incremented in thread_link(). The old test tried to not allow more then max_threads_per_proc threads in a process, now it allows to create max_threads_per_proc. My guess is that the reference to mentioned pthread_vfork_test failed because reporter set kern.threads.max_threads_per_proc to 100. The test actually tries to create 101 threads, 1 main + 100 new. --pQC2pbIvkpPv3Ssp Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk1lB7wACgkQC3+MBN1Mb4gAwACgwgvZepbOdMdcFCp8oqPPGFx9 yTIAn39MTj+WGnO7LWPYqNKD+lbxFIQJ =ykZ5 -----END PGP SIGNATURE----- --pQC2pbIvkpPv3Ssp--