From owner-cvs-all Fri Jan 14 10:58:58 2000 Delivered-To: cvs-all@freebsd.org Received: from canonware.com (canonware.com [207.20.242.18]) by hub.freebsd.org (Postfix) with SMTP id E7F67158D5 for ; Fri, 14 Jan 2000 10:55:45 -0800 (PST) (envelope-from jasone@canonware.com) Received: (qmail 16614 invoked by uid 1001); 14 Jan 2000 18:55:13 -0000 Date: Fri, 14 Jan 2000 10:55:13 -0800 From: Jason Evans To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_sysent.c sys_generic.c syscalls.c syscalls.master uipc_socket.c uipc_socket2.c vfs_aio.c src/sys/sys aio.h socketvar.h syscall-hide.h syscall.h syscall.mk sysproto.h Message-ID: <20000114105513.O302@sturm.canonware.com> References: <200001140253.SAA53905@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: ; from bde@zeta.org.au on Sat, Jan 15, 2000 at 01:14:09AM +1100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sat, Jan 15, 2000 at 01:14:09AM +1100, Bruce Evans wrote: > On Thu, 13 Jan 2000, Jason Evans wrote: > > > jasone 2000/01/13 18:53:30 PST > > > > Modified files: > > sys/kern init_sysent.c sys_generic.c syscalls.c > > syscalls.master uipc_socket.c > > uipc_socket2.c vfs_aio.c > > sys/sys aio.h socketvar.h syscall-hide.h > > syscall.h syscall.mk sysproto.h > > Log: > > Add aio_waitcomplete(). Make aio work correctly for socket descriptors. > > Make gratuitous style(9) fixes (me, not the submitter) to make the aio > > code more readable. > > > > PR: kern/12053 > > Submitted by: Chris Sedore > > > > Revision Changes Path > > ... > > 1.65 +634 -503 src/sys/kern/vfs_aio.c > > Don't mix style fixes with new functionality. It makes the diffs hard to > read, and hides the new bugs. This change is a particularly good bad > example. It reformats lots of old code. The diff (-c1) is 25% larger > than the original file. Okay, that makes sense. So the next time this comes up, should I check in the style changes before or after the functionality changes? Jason To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message