From owner-cvs-src@FreeBSD.ORG  Fri Sep  7 09:19:23 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C3F7F16A418;
	Fri,  7 Sep 2007 09:19:23 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id B301213C465;
	Fri,  7 Sep 2007 09:19:23 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l879JNS8084463;
	Fri, 7 Sep 2007 09:19:23 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l879JNZJ084462;
	Fri, 7 Sep 2007 09:19:23 GMT (envelope-from rwatson)
Message-Id: <200709070919.l879JNZJ084462@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Fri, 7 Sep 2007 09:19:23 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/netinet tcp_subr.c tcp_timer.c tcp_timer.h
 tcp_usrreq.c tcp_var.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Sep 2007 09:19:23 -0000

rwatson     2007-09-07 09:19:23 UTC

  FreeBSD src repository

  Modified files:
    sys/netinet          tcp_subr.c tcp_timer.c tcp_timer.h 
                         tcp_usrreq.c tcp_var.h 
  Log:
  Back out tcp_timer.c:1.93 and associated changes that reimplemented the many
  TCP timers as a single timer, but retain the API changes necessary to
  reintroduce this change.  This will back out the source of at least two
  reported problems: lock leaks in certain timer edge cases, and TCP timers
  continuing to fire after a connection has closed (a bug previously fixed and
  then reintroduced with the timer rewrite).
  
  In a follow-up commit, some minor restylings and comment changes performed
  after the TCP timer rewrite will be reapplied, and a further change to allow
  the TCP timer rewrite to be added back without disturbing the ABI.  The new
  design is believed to be a good thing, but the outstanding issues are
  leading to significant stability/correctness problems that are holding
  up 7.0.
  
  This patch was generated by silby, but is being committed by proxy due to
  poor network connectivity for silby this week.
  
  Approved by:    re (kensmith)
  Submitted by:   silby
  Tested by:      rwatson, kris
  Problems reported by:   peter, kris, others
  
  Revision  Changes    Path
  1.297     +12 -12    src/sys/netinet/tcp_subr.c
  1.96      +242 -306  src/sys/netinet/tcp_timer.c
  1.38      +5 -10     src/sys/netinet/tcp_timer.h
  1.161     +4 -7      src/sys/netinet/tcp_usrreq.c
  1.156     +5 -1      src/sys/netinet/tcp_var.h