From nobody Sun Feb 26 16:30:22 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PPpyS6w6Wz3tmLT; Sun, 26 Feb 2023 16:30:24 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PPpyS4413z3v14; Sun, 26 Feb 2023 16:30:24 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-17227cba608so5215419fac.3; Sun, 26 Feb 2023 08:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=P4tv2lgMb3yHCBEE5A8OvsJ2MtLEgyHSSJ/RRAyPk50=; b=ceb9qdc7h5FfmG/hUdavd4bPDQfwT9Gw7+c3UIWCj9oWv5LfdUKZpqy8SBxdTtiahX m52n0GjICTKSCogYcuv39eBe5Yrh8QnECIJm4rDxXds2LIkeZpYuZH1e8hMxZGyFBaHj 0npLIimgVdddTRB8BvfQyJLuzinSHa5+/RFnzFL/uaYIDunp75TvK0ToQroSbbCKH3Ob W1P+rN9p6OQHkpLKNvBlnxpPadS89ZOqnZ3vCMsBmKmmFmKS+qh2Vz9v3r8m+FLwfb8e Hl9S0sYPqpGoPYcSco0RnUXkZJjcT82RG6wvFWBGxmkjmeRHr3hrQ3yT7EQOO3ve3ksN 1how== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P4tv2lgMb3yHCBEE5A8OvsJ2MtLEgyHSSJ/RRAyPk50=; b=1lsCtHjYz+/3cCfBBdKOuM+zBGC13T7rds3sehPENf8Or/PNvowRpckBtREUm47nMs 3dp0s7KiFIZoodZ0q5ofOseDfrv4I3bVQGmkqBFW9P6HlB3nq+g+TrW2zBjCJeNvgQrd SmCW993qng0P6d8UhroLF1KHALVASzcOfYFE9ItOt7YzFohJSaSvPshkrouEdp6DOaid ZSSB6R2ia0ejeouqpiesUzhyai7vbxlEftwmAo3AqM4yROzg8Fzj/XCShLDN6pakbc+Z uutCK2LLSxn78BVSw7IYOyNuNakBqjsQf48megMj7/FwafIrQ6d8i3/5tQzqr/1QrBwe HHEA== X-Gm-Message-State: AO0yUKUVGZo05kftgTEaBMaXresaSfNqcKYyDW60YL2AFrJG+UDN5O9o y5k5dn5xBCyqDhejBdQnf732UHEp/BjhJ57sVagYKzUs X-Google-Smtp-Source: AK7set/x1UN0KabKZGAEZBlpxwnntS8Kc7nXvr8ggQIv2yrKKQ56KYx+44NdSJ/KRnw736TBBXTPoCSlVEm7DL0sjE8= X-Received: by 2002:a05:6870:1b09:b0:16e:919d:7974 with SMTP id hl9-20020a0568701b0900b0016e919d7974mr2146443oab.5.1677429023560; Sun, 26 Feb 2023 08:30:23 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Received: by 2002:ac9:4304:0:b0:4c1:4768:8c59 with HTTP; Sun, 26 Feb 2023 08:30:22 -0800 (PST) In-Reply-To: <202302261624.31QGOl8I089368@gitrepo.freebsd.org> References: <202302261624.31QGOl8I089368@gitrepo.freebsd.org> From: Mateusz Guzik Date: Sun, 26 Feb 2023 17:30:22 +0100 Message-ID: Subject: Re: git: b8bb73ab724b - main - pseudofs: Fix LOR in VOP_READDIR. To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4PPpyS4413z3v14 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2001:4860:4864::/48, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 2/26/23, Dag-Erling Sm=C3=B8rgrav wrote: > The branch main has been updated by des: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Db8bb73ab724b19063481dba089c3dc9= a8e1926b1 > > commit b8bb73ab724b19063481dba089c3dc9a8e1926b1 > Author: Dag-Erling Sm=C3=B8rgrav > AuthorDate: 2023-02-26 15:30:53 +0000 > Commit: Dag-Erling Sm=C3=B8rgrav > CommitDate: 2023-02-26 15:30:53 +0000 > > pseudofs: Fix LOR in VOP_READDIR. > > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D20862 > --- > sys/fs/pseudofs/pseudofs_vnops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/fs/pseudofs/pseudofs_vnops.c > b/sys/fs/pseudofs/pseudofs_vnops.c > index eae4c1c71ab9..f4e27b469213 100644 > --- a/sys/fs/pseudofs/pseudofs_vnops.c > +++ b/sys/fs/pseudofs/pseudofs_vnops.c > @@ -897,8 +897,8 @@ pfs_readdir(struct vop_readdir_args *va) > if (!pfs_visible_proc(curthread, pd, proc)) { > _PRELE(proc); > PROC_UNLOCK(proc); > - sx_sunlock(&allproc_lock); > pfs_unlock(pd); > + sx_sunlock(&allproc_lock); > PFS_RETURN (ENOENT); > } > } > this does not fix any LORs. it is legal to *unlock* in any order. --=20 Mateusz Guzik