Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Apr 2017 12:04:13 -0700
From:      Conrad Meyer <cem@freebsd.org>
To:        Dimitry Andric <dim@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r316492 - in head/usr.bin/grep: . regex
Message-ID:  <CAG6CVpVQ1pFdeCg-OJNGcGd1rbJ1CMDEyfEa3FWd9HEsrSfrUw@mail.gmail.com>
In-Reply-To: <B9C5AC3B-1775-4D5D-ADA7-C6CE091F32F5@FreeBSD.org>
References:  <201704041608.v34G8qSo055328@repo.freebsd.org> <4D675D2F-7D6F-4AF2-AE10-5DF19D4158D0@gmail.com> <B9C5AC3B-1775-4D5D-ADA7-C6CE091F32F5@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 4, 2017 at 11:56 AM, Dimitry Andric <dim@freebsd.org> wrote:
> On 4 Apr 2017, at 19:14, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote:
>> Where did xmalloc.c originate from?
>
> GNU.

I believe this to be completely incorrect.

> Almost all software from the GNU project relies on malloc wrappers
> which abort the program on allocation failures.

That is not what bsdgrep's xmalloc() did, if you read the code. It
simply tracks all allocations for basic leak analysis.

Abort on allocation failure would be a perfectly reasonable behavior
for bsdgrep(1), too.

Best,
Conrad



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpVQ1pFdeCg-OJNGcGd1rbJ1CMDEyfEa3FWd9HEsrSfrUw>