From owner-cvs-all@FreeBSD.ORG Sun Sep 2 20:10:49 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C922716A41B for ; Sun, 2 Sep 2007 20:10:49 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with SMTP id 8B18713C46C for ; Sun, 2 Sep 2007 20:10:49 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 26886 invoked by uid 399); 2 Sep 2007 20:10:48 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 2 Sep 2007 20:10:48 -0000 X-Originating-IP: 127.0.0.1 Date: Sun, 2 Sep 2007 13:10:45 -0700 (PDT) From: Doug Barton To: Roman Bogorodskiy In-Reply-To: <200709021108.l82B8Axp085777@repoman.freebsd.org> Message-ID: References: <200709021108.l82B8Axp085777@repoman.freebsd.org> X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://www.FreeBSD.org/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Cc: cvs-ports@FreeBSD.org, linimon@freebsd.org, lofi@freebsd.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/gnupg Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Sep 2007 20:10:49 -0000 On Sun, 2 Sep 2007, Roman Bogorodskiy wrote: > novel 2007-09-02 11:08:10 UTC > > FreeBSD ports repository > > Modified files: > security/gnupg Makefile > Log: > Add RUN_DEPEND on security/pinentry because gpg is almost useless > without it. > > PR: 115760 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=115760 > Submitted by: novel > Approved by: maintainer timeout (1 week, linimon ok) > > Revision Changes Path > 1.106 +2 -1 ports/security/gnupg/Makefile > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/gnupg/Makefile.diff?&r1=1.105&r2=1.106&f=h I don't think this is a good idea for a few reasons. First off, the gnupg port already has a pkg-message that is pretty clear about the fact that you need to pick a pinentry dialog. Second, I don't think that the pinentry port itself is a good choice in its current state. I just did a quick test and as far as I can tell it seems to want to build all of them, which means depending on QT3, and GTK 1 and 2. I sort of think that this might be reasonable if the pinentry port grew OPTIONS, which I would even be willing to work on if lofi thought it was a good idea. But I don't think the overhead of drawing all of the dialogs in is worth it, and I don't see an easy way of guessing which one the user would want by default. Can this change be backed out till there has been a little discussion? Doug -- This .signature sanitized for your protection