From owner-freebsd-testing@FreeBSD.ORG  Sun Mar  2 21:37:28 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 493F1E68
 for <freebsd-testing@freebsd.org>; Sun,  2 Mar 2014 21:37:28 +0000 (UTC)
Received: from mail-qa0-f41.google.com (mail-qa0-f41.google.com
 [209.85.216.41])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 077CE1B5A
 for <freebsd-testing@freebsd.org>; Sun,  2 Mar 2014 21:37:27 +0000 (UTC)
Received: by mail-qa0-f41.google.com with SMTP id j5so2780440qaq.14
 for <freebsd-testing@freebsd.org>; Sun, 02 Mar 2014 13:37:26 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc:content-type;
 bh=f2qRBSdpEAa8Uh2nxLQNVsiHjb7plYpTbJZkSwJpA0E=;
 b=aKdQ5vOu7XwaUfE9KDUI2jtJQ99u3j4EhGJCk4kQlx11/Sk+qFFYuKA84Hd1QEHz5T
 gBsBltRR/cJHk5UOtBM7myITYZhvsN3kHOJ8M8ewxZBlJ1iZFTg8vGq/UMtg0blchA4F
 WsRr1YN0T0xcwxAvUSNC4TLDIzwo2KIw8AKpxSQkxXXcgIZQVwnyLVXL88rPy/iZXnLQ
 tlJ8QRT0V6msL4RHDZtKKxw/KGS9RmuSou9XOx1CwWnc1N5uSU+D+4JYZovnOGOmmj6J
 nuupG2dufj1nqRn00SUow33y6Xw5KFNYbgEAZJsX4iMwxb8IL9qVxNO0k8ragrVVbend
 riKw==
X-Gm-Message-State: ALoCoQmdhyp4TLmnWoTOCFcGyQV2PvdrkIuR+28z4qKG/UjzEKT3cvFh5Rp39UlFFl7r/ZXOf5Lp
X-Received: by 10.140.25.112 with SMTP id 103mr18081643qgs.39.1393795939904;
 Sun, 02 Mar 2014 13:32:19 -0800 (PST)
MIME-Version: 1.0
Sender: jmmv@meroh.net
Received: by 10.96.83.102 with HTTP; Sun, 2 Mar 2014 13:31:59 -0800 (PST)
X-Originating-IP: [108.176.158.82]
In-Reply-To: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com>
References: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com>
From: Julio Merino <jmmv@freebsd.org>
Date: Sun, 2 Mar 2014 16:31:59 -0500
X-Google-Sender-Auth: 1_JijG4vquIvOCZHBjT0GKvYaWY
Message-ID: <CAFY7cWDsR=82ANK8q2-SoVyu6BowdC6hHDwo+s1P7Jt+fy8ZCQ@mail.gmail.com>
Subject: Re: [PATCH] Integrate pjdfstest into the build
To: Garrett Cooper <yanegomi@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>,
 Pawel Jakub Dawidek <pjd@freebsd.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Mar 2014 21:37:28 -0000

On Mon, Jan 27, 2014 at 5:41 AM, Garrett Cooper <yanegomi@gmail.com> wrote:
> Hi all,
>         The attached patch integrates pjdfstest into the build. It also simplifies some logic in tests/sys/Makefile when copying Kyuafile.

Aaand one more time, apologies for the delay.  I think I'm caught up now!

* What's the point of PJDFSTEST_I_KNOW_WHAT_I_AM_DOING?  *Why* is it a
very bad idea to do so?

* The 'tests' path component in pjdfstest/tests/ should go away; it is
redundant.

* Add $FreeBSD$ tags everywhere where missing.

* The test files should move from tools/regression/pjdfstest/ into the
new location under tests/sys/ and be renamed to follow the conventions
under src/test (e.g. xx.t -> xx_test).

Cheers