From owner-svn-src-all@FreeBSD.ORG Thu Jan 21 01:43:23 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D1F12106566B; Thu, 21 Jan 2010 01:43:23 +0000 (UTC) (envelope-from wkoszek@freebsd.czest.pl) Received: from freebsd.czest.pl (l95h.icis.pcz.pl [212.87.224.105]) by mx1.freebsd.org (Postfix) with ESMTP id 4639F8FC1A; Thu, 21 Jan 2010 01:43:22 +0000 (UTC) Received: from freebsd.czest.pl (l95h.icis.pcz.pl [212.87.224.105]) by freebsd.czest.pl (8.14.2/8.14.2) with ESMTP id o0L1ttbK083629; Thu, 21 Jan 2010 02:55:55 +0100 (CET) (envelope-from wkoszek@freebsd.czest.pl) Received: (from wkoszek@localhost) by freebsd.czest.pl (8.14.2/8.14.2/Submit) id o0L1ttMV083628; Thu, 21 Jan 2010 02:55:55 +0100 (CET) (envelope-from wkoszek) Date: Thu, 21 Jan 2010 02:55:55 +0100 From: "Wojciech A. Koszek" To: Alexander Leidinger Message-ID: <20100121015554.GI1990@FreeBSD.org> Mail-Followup-To: Alexander Leidinger , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201001182246.o0IMk6dw000346@svn.freebsd.org> <20100119091500.17856jhlpl7mjsow@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline In-Reply-To: <20100119091500.17856jhlpl7mjsow@webmail.leidinger.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-3.0 (freebsd.czest.pl [212.87.224.105]); Thu, 21 Jan 2010 02:55:55 +0100 (CET) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r202598 - head/sys/compat/linux X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2010 01:43:23 -0000 On Tue, Jan 19, 2010 at 09:15:00AM +0100, Alexander Leidinger wrote: > Quoting "Wojciech A. Koszek" (from Mon, 18 Jan 2010 > 22:46:06 +0000 (UTC)): > >> Author: wkoszek >> Date: Mon Jan 18 22:46:06 2010 >> New Revision: 202598 >> URL: http://svn.freebsd.org/changeset/base/202598 >> >> Log: >> Let us to use our libusb(3) in Linuxolator. >> >> With this change, Linux binaries can work with our libusb(3) when >> it's compiled against our header files on GNU/Linux system -- this >> solves the problem with differences between /dev layouts. >> >> With ported libusb(3), I am able to use my USB JTAG cable with Linux >> binaries that support it. > > The commit log is IMHO omitting the info if you checked (or not) that there > is no linux ioctl in this range. It would also be nice if the comment in > linux_ioctl.h tells to check that there is no clash with a linux ioctl when > the min/max is changed. Sorry for delay. I have tested it against ioctl() calls submitted by ported libusb(3). Apparently, all ioctl() requests in my execution path didn't hit our emulator, thus I was getting warnings about unsupported ioctl(). Thus, I reserved a range for them. However, it looks like conflict exists with Linux *SND* stuff. I believe the easiest solution would be based on picking "untypable" values for commands: #define BSDEMUL_USB_REQUEST _IOWR(3, 1, struct usb_ctl_request) And putting them into linux_ioctl.h just like any other ioctl(). Simple mapping would be provided for those calls to our native USB stack. grep(1) says 3 or 4 passed as a ioctl() should be fine, since none of those seem to be used in Linux. I could bring the same macros to ported libusb(3) easily, so that we'd be using something that Linuxolator can finally understand in a unique way. Does is sound like an acceptable solution? -- Wojciech A. Koszek wkoszek@FreeBSD.org http://FreeBSD.czest.pl/~wkoszek/