From owner-svn-src-all@freebsd.org Fri Jan 3 20:29:43 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6CE341E4EA2; Fri, 3 Jan 2020 20:29:43 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47qGjL3z8Pz4Kgv; Fri, 3 Jan 2020 20:29:42 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f47.google.com with SMTP id c16so12655473ioh.6; Fri, 03 Jan 2020 12:29:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wvtdlUiXg+hdx0hsux/0Wk9tG7YDyen0oP3Qt2C7Nns=; b=P9uC1AS5EtX8qtABNZTHQf1d9wCj/oZ47jLqZjc4HeccDl1EJ5wGHVMYdujNdtxlFH iQuv+KQm+0vj5QtHLMZzhIfXaU+AeylvvrdE77dYxHOEANq0M0yPg2Q6oSRN/s+oEjgq 1X/SSnb3m1k0UMQXkPXeXXLBp0nKN6I5d6+XKKZPp37LqgmMR9fKZpjk85TJUXHJaRCA OXlFsCze3Xm0l5Jukl4hjx7K/hOJBNvPTjvPgZxqp+WgxSD5whbMQsuxBwAkNz+H7afI K0JO1wVQ50swHGOZEnfW/fKUQIkgGqFFnYBL52uPNYxpCyrJJPq4tcXWm/Kr9EWWq6jw nIYw== X-Gm-Message-State: APjAAAU1SlroHES3z6Y0dQnAfcCBYNtCzBkNPozIHVPGadekPpOSBkqw OZ8YZPJSHnuTzE3Y0UFUKQ1LlRQYcRb3O+SqE3qZdw== X-Google-Smtp-Source: APXvYqwTpEhrFWVRnJqvk8s4FAxdPPxWeDRb8rGOqt9b5Uan0ttpYWrfp7bYiBwjRWCJ8hNU/LiDrnyP7bu0DRhOudY= X-Received: by 2002:a6b:6712:: with SMTP id b18mr61183955ioc.256.1578083381480; Fri, 03 Jan 2020 12:29:41 -0800 (PST) MIME-Version: 1.0 References: <202001031811.003IBtqt019822@repo.freebsd.org> In-Reply-To: From: Ed Maste Date: Fri, 3 Jan 2020 15:29:29 -0500 Message-ID: Subject: Re: svn commit: r356322 - head/share/mk To: Enji Cooper Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47qGjL3z8Pz4Kgv X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[47.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.00)[ip: (-4.98), ipnet: 209.85.128.0/17(-3.11), asn: 15169(-1.86), country: US(-0.05)]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[47.166.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2020 20:29:43 -0000 On Fri, 3 Jan 2020 at 14:23, Enji Cooper wrote: > > Thank you for doing this <3. FWIW, MK_TESTS:= no should have also > covered this, but no real harm nor foul in making it explicit. Hmm, it looks like MK_TESTS_SUPPORT == no turns off MK_GOOGLETEST but MK_TESTS does not. I'm happy enough if someone wants to clean this up further, but IMO it's not worth putting in a lot of effort just yet; in a few months GCC 4.2.1 and all of its build infrastructure will be out of the tree and there may be many more opportunities to simplify src.opts.mk logic. In particular all of the ${COMPILER_FEATURES:Mc++11} tests can disappear.