From owner-cvs-all@FreeBSD.ORG  Fri Jan 11 22:15:21 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 75A6816A528; Fri, 11 Jan 2008 22:15:21 +0000 (UTC)
Date: Fri, 11 Jan 2008 22:15:21 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Stanislav Sedov <stas@FreeBSD.org>
Message-ID: <20080111221521.GA75716@FreeBSD.org>
References: <200701050755.l057tKlT066265@repoman.freebsd.org>
	<20080111212612.GE22695@dracon.ht-systems.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20080111212612.GE22695@dracon.ht-systems.ru>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Martin Wilke <miwi@FreeBSD.org>
Subject: Re: cvs commit: ports/lang Makefile ports/lang/ruby-extensions
	Makefile distinfo pkg-descr pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2008 22:15:21 -0000

On Sat, Jan 12, 2008 at 12:26:12AM +0300, Stanislav Sedov wrote:
> On Fri, Jan 05, 2007 at 07:55:20AM +0000 Martin Wilke mentioned:
> > miwi        2007-01-05 07:55:20 UTC
> > 
> >   FreeBSD ports repository
> > 
> >   Modified files:
> >     lang                 Makefile 
> >   Added files:
> >     lang/ruby-extensions Makefile distinfo pkg-descr pkg-plist 
> >   Log:
> >   This project defines various useful extensions to Ruby's standard classes,
> >   including many of those captured at on the Wiki at StandardClassExtensions.
> >   They are thoroughly documented and tested. See the project homepage for API
> >   documentation.
> >   
> >   Author: Gavin Sinclair <gsinclair@soyabean.com.au>
> >   WWW:    http://extensions.rubyforge.net
> >   
> 
> This port sucks in number of ways, which submitter should be informed in:
> 1) It executes rake directly without PATH specification, which won't work if
>    LOCALBASE/bin isn't in PATH.
> 2) It installs files using CP which is highly discouraged since it doesn't
>    set correct permissions on files.

I'd really like to see sat@'s thorough reviews back.

/me ducks, runs.

./danfe