From nobody Thu Dec 29 22:12:51 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NjjM41cVkz1J58q; Thu, 29 Dec 2022 22:13:04 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4NjjM36gM4z3tHF; Thu, 29 Dec 2022 22:13:03 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 2BTMCuMJ007767 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 30 Dec 2022 00:12:59 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 2BTMCuMJ007767 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 2BTMCp9B007758; Fri, 30 Dec 2022 00:12:51 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 30 Dec 2022 00:12:51 +0200 From: Konstantin Belousov To: Mike Karels Cc: Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 68912701700c - main - ffs_suspend.c: clean up includes Message-ID: References: <202212292056.2BTKuOIu047460@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on tom.home X-Rspamd-Queue-Id: 4NjjM36gM4z3tHF X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Thu, Dec 29, 2022 at 03:19:39PM -0600, Mike Karels wrote: > On 29 Dec 2022, at 14:56, Konstantin Belousov wrote: > > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=68912701700ca3230f3e2d4b7858a038f884a327 > > > > commit 68912701700ca3230f3e2d4b7858a038f884a327 > > Author: Konstantin Belousov > > AuthorDate: 2022-12-28 18:17:53 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2022-12-29 20:55:39 +0000 > > > > ffs_suspend.c: clean up includes > > > > Order includes alphabetically. > > Remove unneeded sys/param.h, it is already included by sys/systm.h. > > I am surprised by the last change; it seems contrary to the spirit (at > least) of style(9). In particular, style(9) says that param.h or types.h > goes first (or after cdefs.h), followed by systm.h if needed. I don’t > object to direct inclusion of param.h even if one of the 14 other headers > in sys/ that include param.h are also included. This is what I was told (continuosly) by Bruce. No need to include sys/param.h if sys/systm.h is used in kernel, at least. > > Mike > > > Reviewed by: mckusick > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 week > > Differential revision: https://reviews.freebsd.org/D37896 > > --- > > sys/ufs/ffs/ffs_suspend.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/sys/ufs/ffs/ffs_suspend.c b/sys/ufs/ffs/ffs_suspend.c > > index d13097109758..e7c976b6e921 100644 > > --- a/sys/ufs/ffs/ffs_suspend.c > > +++ b/sys/ufs/ffs/ffs_suspend.c > > @@ -33,15 +33,14 @@ > > #include > > __FBSDID("$FreeBSD$"); > > > > -#include > > #include > > #include > > -#include > > -#include > > -#include > > #include > > +#include > > #include > > +#include > > #include > > +#include > > > > #include