From owner-freebsd-hackers@FreeBSD.ORG  Tue Jul  5 09:04:20 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 133741065670;
	Tue,  5 Jul 2011 09:04:20 +0000 (UTC)
	(envelope-from cbergstrom@pathscale.com)
Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com
	[209.85.210.54])
	by mx1.freebsd.org (Postfix) with ESMTP id DDB328FC13;
	Tue,  5 Jul 2011 09:04:19 +0000 (UTC)
Received: by pzk27 with SMTP id 27so3868510pzk.13
	for <multiple recipients>; Tue, 05 Jul 2011 02:04:19 -0700 (PDT)
Received: by 10.68.6.228 with SMTP id e4mr7814682pba.216.1309855271214;
	Tue, 05 Jul 2011 01:41:11 -0700 (PDT)
Received: from [192.168.1.33] (ppp-58-8-62-202.revip2.asianet.co.th
	[58.8.62.202])
	by mx.google.com with ESMTPS id q5sm4354057pbk.58.2011.07.05.01.41.07
	(version=SSLv3 cipher=OTHER); Tue, 05 Jul 2011 01:41:09 -0700 (PDT)
Message-ID: <4E12CF5E.20602@pathscale.com>
Date: Tue, 05 Jul 2011 15:46:22 +0700
From: =?UTF-8?B?IkMuIEJlcmdzdHLDtm0i?= <cbergstrom@pathscale.com>
User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US;
	rv:1.9.2.7) Gecko/20101031 Lightning/1.0b2 Thunderbird/3.1.1
MIME-Version: 1.0
To: Robert Millan <rmh@debian.org>
References: <CAOfDtXPkR9FvpXB4EFj60OFnPR_skNTzu3LyLjCmmrs=HZXe_g@mail.gmail.com>
In-Reply-To: <CAOfDtXPkR9FvpXB4EFj60OFnPR_skNTzu3LyLjCmmrs=HZXe_g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@freebsd.org, Ed Maste <emaste@freebsd.org>
Subject: Re: [PATCH] FreeBSD compiler extensions
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2011 09:04:20 -0000

  On 07/ 5/11 03:27 PM, Robert Millan wrote:
> This patch conditionalizes a pair of FreeBSD compiler extensions so
> that its CFLAGS are only used on FreeBSD.
Were I work we don't spend much time on compiling any kernel, but I'm 
superficially curious about the actual code which necessitates you 
needing these different flags.  Is this for performance, correctness or 
both?

(If you have any sort of reduced code example you can share that would 
be great)

 From a biased vendor perspective - less lock-in to a single compiler is 
usually a good thing.  (The linux kernel may be the best example of what 
not to do.)  Sorry I can't comment on the correctness of the patch.

./C