From owner-svn-src-head@freebsd.org Thu Mar 30 23:07:53 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 501CED26985; Thu, 30 Mar 2017 23:07:53 +0000 (UTC) (envelope-from David.Somayajulu@cavium.com) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0070.outbound.protection.outlook.com [104.47.34.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1826CC5; Thu, 30 Mar 2017 23:07:51 +0000 (UTC) (envelope-from David.Somayajulu@cavium.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mYHR1Hl5VTlG7KTgdAUqTExngu5nv83l/zDi+EuCeN0=; b=evegxyL3hz8eTj3UzOzZ4BlOHxblCkycdb5Mgu6lSjYf7yyNyGwSCrCen3d+Cq7HXoxAiQB6gcbAPM1s7v7jMzaFuWk71Fyz7ZSmk60gdQAgJGBICC3g36+QKIc2/vMvIz78jtltp33k6MkNzJp9UUAJnRFaSB1qZdRk3UdMIa0= Received: from BY2PR07MB1474.namprd07.prod.outlook.com (10.162.76.152) by BY2PR07MB1473.namprd07.prod.outlook.com (10.162.76.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Thu, 30 Mar 2017 23:07:50 +0000 Received: from BY2PR07MB1474.namprd07.prod.outlook.com ([10.162.76.152]) by BY2PR07MB1474.namprd07.prod.outlook.com ([10.162.76.152]) with mapi id 15.01.0977.021; Thu, 30 Mar 2017 23:07:50 +0000 From: "Somayajulu, David" To: hiren panchasara , David C Somayajulu CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: RE: svn commit: r316309 - head/sys/dev/qlxgbe Thread-Topic: svn commit: r316309 - head/sys/dev/qlxgbe Thread-Index: AQHSqadk1yJwSnN9yEeerdOGAow+7qGuABeAgAAAWVA= Date: Thu, 30 Mar 2017 23:07:50 +0000 Message-ID: References: <201703302243.v2UMhX2s011405@repo.freebsd.org> <20170330230227.GH1016@strugglingcoder.info> In-Reply-To: <20170330230227.GH1016@strugglingcoder.info> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: strugglingcoder.info; dkim=none (message not signed) header.d=none;strugglingcoder.info; dmarc=none action=none header.from=cavium.com; x-originating-ip: [198.186.0.2] x-microsoft-exchange-diagnostics: 1; BY2PR07MB1473; 7:YS/ap+gQ2O9smiON4S6SPl+mLXT+m3YlLHnURxZVeBgxO/FPn/g6CH2cldqOZRBBfT/Oo4Zd1hyUr8Xgf6+7CroPvYFkrdXZmaFBApiFB2uL4Blo4Kw0u2vd2642aTnkBAmiQvcBilPKUCOVwvp5CPI9oKV3M0Y1xqpjpwePE7bJKZgCU7E3dBmRLvfqkKER33vOSJe2b0+Ne/oX9T7WZEzXj46wrOktm8qXP85QxrLRA+MyIHmf7DZRtBbdFxYIe4bINjq6aLvS5gUVYcHpVAHG+6HbjwH0XP+VN1ih86QtijuTalqBbezvNTbMWupEmIVS7kVLNPmNKKQJHH87Zg== x-ms-office365-filtering-correlation-id: 223a54fc-00be-4c80-6492-08d477c196b6 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081); SRVR:BY2PR07MB1473; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(56005881305849); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006077)(93001077)(3002001)(6041248)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123560025)(6072148); SRVR:BY2PR07MB1473; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB1473; x-forefront-prvs: 02622CEF0A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(39840400002)(39400400002)(39410400002)(39850400002)(13464003)(377454003)(24454002)(3660700001)(8936002)(3280700002)(74316002)(2906002)(6306002)(8676002)(122556002)(53936002)(2950100002)(55016002)(2900100001)(86362001)(77096006)(6506006)(54906002)(99286003)(6436002)(81166006)(9686003)(7696004)(5660300001)(4326008)(189998001)(6116002)(7736002)(33656002)(6246003)(76176999)(38730400002)(50986999)(54356999)(229853002)(66066001)(25786009)(53546009)(305945005)(3846002)(102836003); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB1473; H:BY2PR07MB1474.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2017 23:07:50.4980 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB1473 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 23:07:53 -0000 Hi Hiren, > I know this is not a new topic but a little more descriptive commit-log w= ould have been nicer. Also, you should update the manpage reflecting this c= hange. i.e. now it also supports software LRO when h/w LRO is disabled. Will do. Sorry about that. > Do you know of a case where one would want to disable h/w lro and enable = s/w lro? I guess where you want to free up nic and make cpu do more work? I was under the impression as well, that s/w lro is moot, if h/w lro was av= ailable, till one costumer asked for it. Not sure what the use case is. Thanks David S. -----Original Message----- From: hiren panchasara [mailto:hiren@strugglingcoder.info]=20 Sent: Thursday, March 30, 2017 4:02 PM To: David C Somayajulu Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freeb= sd.org Subject: Re: svn commit: r316309 - head/sys/dev/qlxgbe On 03/30/17 at 10:43P, David C Somayajulu wrote: > Author: davidcs > Date: Thu Mar 30 22:43:32 2017 > New Revision: 316309 > URL: https://svnweb.freebsd.org/changeset/base/316309 >=20 > Log: > Add support for optional Soft LRO Hi David, I know this is not a new topic but a little more descriptive commit-log wou= ld have been nicer. Also, you should update the manpage reflecting this cha= nge. i.e. now it also supports software LRO when h/w LRO is disabled. Do you know of a case where one would want to disable h/w lro and enable s/= w lro? I guess where you want to free up nic and make cpu do more work? Cheers, Hiren