From owner-freebsd-net@FreeBSD.ORG Tue Nov 13 10:24:35 2012 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 18DD5D03; Tue, 13 Nov 2012 10:24:35 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 7FF6D8FC12; Tue, 13 Nov 2012 10:24:34 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id qADAOQXJ020351; Tue, 13 Nov 2012 14:24:26 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id qADAOQlN020350; Tue, 13 Nov 2012 14:24:26 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 13 Nov 2012 14:24:26 +0400 From: Gleb Smirnoff To: Andre Oppermann Subject: Re: svn commit: r240494 - in head: contrib/pf/man contrib/pf/pfctl include sbin/pfctl sbin/pfctl/missing share/man/man4 share/man/man5 sys/conf sys/contrib/pf sys/modules/dummynet sys/modules/ipfw sys/... Message-ID: <20121113102426.GA20289@FreeBSD.org> References: <201209141151.q8EBppm1014858@svn.freebsd.org> <20121113021140.GB260@dragon.NUXI.org> <20121113091713.GF27927@FreeBSD.org> <50A21F1B.5090607@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <50A21F1B.5090607@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, freebsd-net@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, David O'Brien X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2012 10:24:35 -0000 On Tue, Nov 13, 2012 at 11:21:15AM +0100, Andre Oppermann wrote: A> On 13.11.2012 10:17, Gleb Smirnoff wrote: A> > On Mon, Nov 12, 2012 at 06:11:40PM -0800, David O'Brien wrote: A> > D> On Fri, Sep 14, 2012 at 11:51:51AM +0000, Gleb Smirnoff wrote: A> > D> > Log: A> > D> > o Create directory sys/netpfil, where all packet filters should A> > D> > reside, and move there ipfw(4) and pf(4). A> > D> > o Move most modified parts of pf out of contrib. A> > D> A> > D> Why didn't contrib/ipfilter/ move to sys/netpfil/ as well? A> > D> A> > D> Having 1/3 of our packet filters not there (sys/netpfil) might suggest we A> > D> shouldn't create sys/netpfil/ A> > A> > ipfilter is really selfcontained and is a contrib code. A> A> Though it can't decide whether to really live in contrib or A> as part of FreeBSD. Also it hasn't been updated in a long A> time and the official version has progressed quite a bit. A> A> IMHO the version we have should either go away and be replaced A> with a fresh up to date import through the vendor channel, or A> move to netpfil. A> A> Would be a great task for a junior kernel hacker. I don't see any reason to remove it since it builds fine and isn't any obstacle in further development of FreeBSD. Let it be there while it works. -- Totus tuus, Glebius.